Add a rule to detect string members in runtime-evaluated unions#9143
Merged
charliermarsh merged 1 commit intomainfrom Dec 16, 2023
Merged
Add a rule to detect string members in runtime-evaluated unions#9143charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
e777927 to
1c08d43
Compare
Contributor
|
MichaReiser
reviewed
Dec 15, 2023
Comment on lines
+29
to
+32
| /// Use instead: | ||
| /// ```python | ||
| /// var: str | int | ||
| /// ``` |
Member
There was a problem hiding this comment.
Would var: "str | int" be valid too?
konstin
approved these changes
Dec 15, 2023
4a9499c to
4eeaec2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A common mistake is to add quotes around one member in an
X | Y-style type union, as in:However, doing so will lead to a runtime error if the annotation is runtime-evaluated. This PR lints against such patterns.
Closes #9139.