[flake8-use-pathlib] Add fix for PTH123#20169
Merged
ntBre merged 11 commits intoastral-sh:mainfrom Sep 17, 2025
Merged
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PTH123 | 1684 | 0 | 0 | 1684 | 0 |
Contributor
Author
|
I'm not sure which tests should be included in the tests files, but i tested in this file: The first line with # ruff: noqa: SIM115, PLW1514, FBT003
import builtins
from pathlib import Path
_file = "file.txt"
_x = ("r+", -1)
r_plus = "r+"
builtins.open(file=_file) # noqa: PTH123
builtins.open(file=_file)
Path(_file).open()
open(mode="wb", file=_file) # noqa: PTH123
open(mode="wb", file=_file)
Path(_file).open(mode="wb")
open(mode="r+", buffering=-1, file=_file, encoding="utf-8") # noqa: PTH123
open(mode="r+", buffering=-1, file=_file, encoding="utf-8")
Path(_file).open(mode="r+", buffering=-1, encoding="utf-8")
open(_file, "r+", -1, None, None, None) # noqa: PTH123
open(_file, "r+", -1, None, None, None)
Path(_file).open("r+", -1, None, None, None)
open(_file, "r+", -1, None, None, None, closefd=True, opener=None) # noqa: PTH123
open(_file, "r+", -1, None, None, None, closefd=True, opener=None)
Path(_file).open("r+", -1, None, None, None)
open(_file, mode="r+", buffering=-1, encoding=None, errors=None, newline=None) # noqa: PTH123
open(_file, mode="r+", buffering=-1, encoding=None, errors=None, newline=None)
Path(_file).open(mode="r+", buffering=-1, encoding=None, errors=None, newline=None)
open(buffering=- 1, file=_file, encoding= "utf-8") # noqa: PTH123
open(buffering=- 1, file=_file, encoding= "utf-8")
Path(_file).open(buffering=-1, encoding="utf-8")
open(_file, "r+", - 1, None, None, None, True, None) # noqa: PTH123
open(_file, "r+", - 1, None, None, None, True, None)
Path(_file).open("r+", -1, None, None, None)
open(_file, "r+ ", - 1) # noqa: PTH123
open(_file, "r+ ", - 1)
Path(_file).open("r+ ", -1)
open(_file, f" {r_plus} ", - 1) # noqa: PTH123
open(_file, f" {r_plus} ", - 1)
Path(_file).open(f" {r_plus} ", -1)
# Only diagnostic
open()
open(_file, *_x)
open(_file, "r+", unknown=True)
open(_file, "r+", closefd=False)
open(_file, "r+", None, None, None, None, None, None, None) |
ntBre
reviewed
Sep 11, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Thanks! I think you could add those tests to a new file called PTH123.py. It looks like there's some overlap with the test you added in import_from.py, so we could either add the additional file or just add more cases there?
This looks good to me overall, just a few minor suggestions.
Contributor
Author
|
i don't think that's the way to fix it either |
ntBre
reviewed
Sep 12, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Thanks! Just two more minor things, but I think this looks good otherwise.
ntBre
approved these changes
Sep 17, 2025
Contributor
Author
|
I guess I forgot about that, thanks for the change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2331
Test Plan
cargo nextest run flake8_use_pathlib