Skip to content

[airflow] Argument fail_stop in DAG has been renamed as fail_fast (AIR302)#15633

Merged
dhruvmanila merged 1 commit intoastral-sh:mainfrom
astronomer:extend-AIR302
Jan 22, 2025
Merged

[airflow] Argument fail_stop in DAG has been renamed as fail_fast (AIR302)#15633
dhruvmanila merged 1 commit intoastral-sh:mainfrom
astronomer:extend-AIR302

Conversation

@Lee-W
Copy link
Copy Markdown
Contributor

@Lee-W Lee-W commented Jan 21, 2025

Summary

argument fail_stop in DAG has been renamed as fail_fast (AIR302)

Test Plan

a test fixture has been updated

@AlexWaygood AlexWaygood removed their request for review January 21, 2025 11:03
@MichaReiser
Copy link
Copy Markdown
Member

MichaReiser commented Jan 21, 2025

I think you need to rebase this change or something else went wrong :)

@Lee-W Lee-W changed the base branch from extend-AIR302 to main January 21, 2025 15:37
@Lee-W
Copy link
Copy Markdown
Contributor Author

Lee-W commented Jan 21, 2025

I think you need to rebase this change or something else went wrong :)

yep just noticed the base branch is not main 🤔

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

dhruvmanila
dhruvmanila approved these changes Jan 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhruvmanila dhruvmanila changed the title [airflow]: argument fail_stop in DAG has been renamed as fail_fast (AIR302) [airflow] Argument fail_stop in DAG has been renamed as fail_fast (AIR302) Jan 22, 2025
@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule preview Related to preview mode features labels Jan 22, 2025
@dhruvmanila dhruvmanila merged commit 1e05353 into astral-sh:main Jan 22, 2025
@Lee-W Lee-W deleted the extend-AIR302 branch January 23, 2025 08:50
@BrewTestBot BrewTestBot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@carljm carljm Awaiting requested review from carljm

@MichaReiser MichaReiser Awaiting requested review from MichaReiser

@sharkdp sharkdp Awaiting requested review from sharkdp

Assignees

No one assigned

Labels

preview Related to preview mode features rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lee-W @MichaReiser @dhruvmanila