[ruff] Add rule forbidding map(int, package.__version__.split('.')) (RUF048)#14373
Merged
AlexWaygood merged 8 commits intoastral-sh:mainfrom Nov 18, 2024
Merged
[ruff] Add rule forbidding map(int, package.__version__.split('.')) (RUF048)#14373AlexWaygood merged 8 commits intoastral-sh:mainfrom
ruff] Add rule forbidding map(int, package.__version__.split('.')) (RUF048)#14373AlexWaygood merged 8 commits intoastral-sh:mainfrom
Conversation
Contributor
|
AlexWaygood
reviewed
Nov 16, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks!
I wonder if the rule should also flag [int(x) for x in __version__] and (int(x) for x in __version__)? But that could always be done as a followup.
Contributor
Author
|
@AlexWaygood Thanks! All fixed. |
ruff] tuple(map(int, package.__version__.split('.'))) (RUF048)ruff] Add rule forbidding map(int, package.__version__.split('.')) (RUF048)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #12961.
Test Plan
cargo nextest runandcargo insta test.