Detect automagic-like assignments in notebooks#9653
Merged
charliermarsh merged 1 commit intomainfrom Jan 29, 2024
Merged
Conversation
This was referenced Jan 26, 2024
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| F401 | 2 | 0 | 2 | 0 | 0 |
| F821 | 1 | 0 | 1 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -3 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)
mlflow/mlflow (+0 -3 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --preview
- examples/llms/RAG/question-generation-retrieval-evaluation.ipynb:cell 14:1:1: F821 Undefined name `df` - examples/llms/RAG/question-generation-retrieval-evaluation.ipynb:cell 4:14:8: F401 [*] `requests` imported but unused - examples/llms/RAG/question-generation-retrieval-evaluation.ipynb:cell 4:16:17: F401 [*] `bs4.BeautifulSoup` imported but unused
Changes by rule (2 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| F401 | 2 | 0 | 2 | 0 | 0 |
| F821 | 1 | 0 | 1 | 0 | 0 |
Member
Author
|
Ecosystem checks are correct (i.e., they were false positives before the change). |
dhruvmanila
approved these changes
Jan 29, 2024
e1b7b00 to
67c19dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given a statement like
colors = 6, we currently treat the cell as an automagic (sincecolorsis an automagic) -- i.e., we assume it's equivalent to%colors = 6. This PR adds some additional detection whereby if the statement is an assignment, we avoid treating it as such. I audited the list of automagics, and I believe this is safe for all of them.Closes #8526.
Closes #9648.
Test Plan
cargo test