Skip to content

Add necessary permissions for cargo-dist Docker build#12072

Merged
MichaReiser merged 1 commit intomainfrom
charlie/docker
Jun 27, 2024
Merged

Add necessary permissions for cargo-dist Docker build#12072
MichaReiser merged 1 commit intomainfrom
charlie/docker

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Jun 27, 2024

Summary

We have to do the same thing in uv: https://github.com/astral-sh/uv/blob/bf46792839e6d3dbb09d31aa497b9945b8f5151b/.github/workflows/release.yml#L103.

I think I undid this change locally while testing, it was definitely in the branch at one point!

@charliermarsh charliermarsh added the release Related to the release process label Jun 27, 2024
@MichaReiser MichaReiser merged commit 244b923 into main Jun 27, 2024
@MichaReiser MichaReiser deleted the charlie/docker branch June 27, 2024 15:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 27, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

demisto/content (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'unfixable' -> 'lint.unfixable'
  - 'per-file-ignores' -> 'lint.per-file-ignores'
warning: `PGH001` has been remapped to `S307`.
warning: `PGH002` has been remapped to `G010`.
warning: `PLR1701` has been remapped to `SIM101`.
ruff failed
  Cause: Selection of deprecated rule `E999` is not allowed when preview is enabled.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

demisto/content (error) 

ruff format --preview --exclude Packs/ThreatQ/Integrations/ThreatQ/ThreatQ.py

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'unfixable' -> 'lint.unfixable'
  - 'per-file-ignores' -> 'lint.per-file-ignores'
warning: `PGH001` has been remapped to `S307`.
warning: `PGH002` has been remapped to `G010`.
warning: `PLR1701` has been remapped to `SIM101`.
ruff failed
  Cause: Selection of deprecated rule `E999` is not allowed when preview is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@zanieb zanieb zanieb approved these changes

Assignees

No one assigned

Labels

release Related to the release process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charliermarsh @MichaReiser @zanieb