Add isInThePast and isInTheFuture to the missing Java 8 date/time types#2947
Closed
StefanBratanov wants to merge 3 commits intoassertj:mainfrom
Closed
Add isInThePast and isInTheFuture to the missing Java 8 date/time types#2947StefanBratanov wants to merge 3 commits intoassertj:mainfrom
isInThePast and isInTheFuture to the missing Java 8 date/time types#2947StefanBratanov wants to merge 3 commits intoassertj:mainfrom
Conversation
Member
|
Integrated thanks @StefanBratanov ! |
isInThePast and isInTheFuture to the missing java 8 date/timeisInThePast and isInTheFuture to the missing Java 8 date/time
isInThePast and isInTheFuture to the missing Java 8 date/timeisInThePast and isInTheFuture to the missing Java 8 date/time types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List:
isPast()andisFuture()methods for asserting dates #2932InstantLocalDateTimeOffsetDateTimeZonedDateTimesince they follow the same patterns. Decided it makes sense to make them one PR.invoke_api_methodandverify_internal_effectsfor theZonedDateTimeAssertand theOffsetDateTimeAsserttests. I implemented them as no-op.