Conversation
b4ae9f0 to
7fdd4ef
Compare
c1ac74b to
764cc7f
Compare
764cc7f to
238a1f9
Compare
238a1f9 to
9ebe4ae
Compare
slawekjaranowski
left a comment
There was a problem hiding this comment.
An integration test will be appreciated for such feature.
|
is it possible to have an IT test? as I cannot see any test here. thanks |
Improve description
Done now, you find it in https://github.com/apache/maven-surefire/pull/667/files#diff-311598b970ad59d912704889726abb7abbf6d92d3d5382a94d85c8c686ab24b9R21 |
|
For all non POM/dependency and POM/plugins/plugin/dependency elements, especially for plugin config like this one (or like compiler anno processor is, etc) we MUST BE CLEAR that it works ONLY for external dependencies. These elements do NOT participate in project topological sorting, hence, becomes impossible to use some reactor project for these (without hacks). Moreover, if using reactor artifacts, this is one of the reasons why users are forced to to See for example here https://issues.apache.org/jira/browse/MNG-6877 |
|
In fact, IMHO we should revisit ALL these plugins having "artifact-like" (GAV) parameters and using resolver to resolve them, and
Biggest problem with parameters like this is when using in-reactor artifact, "by chance" the ordering may be good, and seemingly everything works, but then user changes something completely unrelated (ie. adds a new module to build), that changes build order, and suddenly this breaks. In this situations is hard to figure out why breakage happened. |
…refire/AbstractSurefireMojo.java
|
Resolve #3151 |
No description provided.