Skip to content

update commons-io to 2.12.0#653

Merged
michael-o merged 1 commit intomasterfrom
commons
May 30, 2023
Merged

update commons-io to 2.12.0#653
michael-o merged 1 commit intomasterfrom
commons

Conversation

@elharo
Copy link
Copy Markdown
Contributor

@elharo elharo commented May 29, 2023

No description provided.

@elharo elharo requested a review from michael-o May 29, 2023 22:33
@michael-o michael-o merged commit e0e89e4 into master May 30, 2023
@michael-o michael-o deleted the commons branch May 30, 2023 18:04
@slawekjaranowski
Copy link
Copy Markdown
Member

why we not have an issue for it ... when we not need issue? - do we have such rules or agreements?
sorry for such questions 😄 - but I see that many PR are without jira issues, so I'm interesting in it.

@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Jun 2, 2023

We honestly don't seem to have any consensus on filing issues for straightforward dependency upgrades like this one. I've been told by some reviewers on some PRs to file issues and on others by other reviewers not to file issues.

If we're going to use dependabot or renovatebot, requiring Jira issues mostly defeats the purpose.

Unless it resolves an active bug in the Maven project itself — not the dependency — my preference is not to file an issue. And if it does resolve a bug, the issue should focus on the bug, not the dependency upgrade. As a user I prefer to not have the release notes cluttered with dependency upgrades that have no visible effect on my work.

@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Jun 2, 2023

FYI commit messages are the same. Different reviewers request different and sometimes contradictory commit conventions. There aren't any established project wide standards for this that anyone pays attention to.

@slachiewicz
Copy link
Copy Markdown
Member

@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Jun 2, 2023

I suppose there's some dispute about what constitutes a "trivial change". Again, some reviewers tell me not to file issues for this sort of thing. Some tell me to file issues. There simply isn't consensus here. And if we require Jira issues for every dependency change, dependabot really doesn't work. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants