[SUREFIRE-2139] Raise plexus-java to 1.1.2 for proper Java 19/20 bytecode support#591
Merged
slawekjaranowski merged 2 commits intoapache:masterfrom Jan 2, 2023
Merged
Conversation
olamy
requested changes
Dec 31, 2022
Member
olamy
left a comment
There was a problem hiding this comment.
We could/should change to use the asm bom.
a5ac921 to
d07d6dc
Compare
Contributor
Author
Done. I've also added a commit to replace JDK18 which is EOL by now with JDK19 in the builds, partly to demonstrate that it works with the changes I made. If that build-related change shouldn't be part of this PR, then let me know and I'll drop it. |
d07d6dc to
56fdc09
Compare
Contributor
Author
|
Well, it's good I did that, because silly me forgot to add the import scope to the asm-bom dependency at first. Now we should be good. |
Contributor
Author
|
Thankfully, @slachiewicz has just released a new version of plexus-java which brings asm 9.4. So I'm going to simplify the pull request and just update the |
slachiewicz
approved these changes
Jan 2, 2023
Closed
|
Resolve #2759 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
SUREFIRE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.