Skip to content

assertj-core must be test scope#826

Merged
olamy merged 1 commit intomasterfrom
fix-assertj-scope
Mar 27, 2025
Merged

assertj-core must be test scope#826
olamy merged 1 commit intomasterfrom
fix-assertj-scope

Conversation

@olamy
Copy link
Copy Markdown
Member

@olamy olamy commented Mar 27, 2025

Signed-off-by: Olivier Lamy olamy@apache.org

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy added the skip-changelog Skip this PR from automatically changelog generation label Mar 27, 2025
@olamy olamy merged commit dfbabe2 into master Mar 27, 2025
40 checks passed
@olamy olamy deleted the fix-assertj-scope branch March 27, 2025 21:13
@github-actions github-actions Bot added this to the next-release milestone Mar 27, 2025
olamy referenced this pull request Mar 27, 2025
Dependencies should be declared where is needed
@jira-importer
Copy link
Copy Markdown

Resolve #2599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SUREFIRE-2297] AssertJ dependency is leaked into project test classpath

3 participants