Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the Javadoc "fix" mojo functionality from the Maven Javadoc plugin, addressing issue #1262. The fix functionality provided an interactive way to automatically fix and update Javadoc comments in Java source files.
Key changes in this removal:
- Removes the fix and test-fix goals and their associated classes
- Removes all test files and integration tests for the fix functionality
- Updates documentation to remove references to the fix goals
Reviewed Changes
Copilot reviewed 49 out of 50 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/org/apache/maven/plugins/javadoc/FixJavadocMojo.java | Removes the main fix mojo implementation |
| src/main/java/org/apache/maven/plugins/javadoc/TestFixJavadocMojo.java | Removes the test-fix mojo implementation |
| src/test/java/org/apache/maven/plugins/javadoc/FixJavadocMojoTest.java | Removes comprehensive unit tests for fix functionality |
| src/test/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojoTest.java | Removes tests for abstract fix mojo functionality |
| src/site/apt/index.apt.vm | Updates site documentation to remove fix goal references |
| src/site/apt/examples/fix-javadocs.apt.vm | Removes entire documentation page for fix functionality |
| src/it/projects/javadoc-fix/* | Removes integration test project for basic fix functionality |
| src/it/projects/javadoc-fix-version/* | Removes integration test for version-specific fix behavior |
| src/it/projects/MJAVADOC-fix | Removes multiple integration tests for various fix-related bug fixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
olamy
approved these changes
Sep 2, 2025
Member
olamy
left a comment
There was a problem hiding this comment.
Great job. Thanks
perfect PR stats :)
|
Why was this feature removed? :D |
Contributor
Author
|
It didn't do anything useful, and generated a lot of noise and cruft when run. It's better not to use it at all. |
Bukama
added a commit
to Bukama/maven-javadoc-plugin
that referenced
this pull request
Nov 8, 2025
Output example was removed by apache#349 (Dec 2024) Fix-Javadoc was removed by apache#1263 (Sep 2025)
Bukama
added a commit
to Bukama/maven-javadoc-plugin
that referenced
this pull request
Nov 9, 2025
Output example was removed by apache#349 (Dec 2024) Fix-Javadoc was removed by apache#1263 (Sep 2025)
Bukama
added a commit
that referenced
this pull request
Nov 10, 2025
Output example was removed by #349 (Dec 2024) Fix-Javadoc was removed by #1263 (Sep 2025) fixes apache/maven-site#1450 fixes apache/maven-site#1449
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moots a bunch of bugs
fixes #1262
fixes #1250
fixes #1251
fixes #1252
fixes #1253
fixes #1254
fixes #1247
fixes #845
fixes #869
fixes #1119