Add ShortCircuitOperator#548
Merged
mistercrunch merged 2 commits intoapache:masterfrom Oct 24, 2015
jlowin:shortcircuit
Merged
Conversation
Member
|
Nice. Very useful indeed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common idiom here is to use a PythonBranchOperator to check if a condition has been met and short circuit the DAG's execution if it hasn't. We started using this ShortCircuitOperator instead because it's much simpler to implement and (critically) to understand: if the condition returns False, DAG execution stops.
This makes it simple to gently introduce non-Task dependencies (file not available, table not updated, don't run on weekends, don't run on holidays, don't run if some metric isn't at a critical level).