Skip to content

fix(core): prevent omission of deferred pipes in full compilation - #60571

Closed
thePunderWoman wants to merge 1 commit into
angular:mainfrom
thePunderWoman:fix-localdeps
Closed

fix(core): prevent omission of deferred pipes in full compilation#60571
thePunderWoman wants to merge 1 commit into
angular:mainfrom
thePunderWoman:fix-localdeps

Conversation

@thePunderWoman

@thePunderWoman thePunderWoman commented Mar 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This prevents a bug where pipes would be excluded from defer dependency generation.

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman thePunderWoman added the area: core Issues related to the framework runtime label Mar 26, 2025
@ngbot ngbot Bot added this to the Backlog milestone Mar 26, 2025
@thePunderWoman
thePunderWoman force-pushed the fix-localdeps branch 3 times, most recently from 06b895b to 5a1498b Compare March 28, 2025 18:17
@thePunderWoman thePunderWoman changed the title fix(core): prevent early exit when using local compilation fix(core): prevent omission of deferred pipes in full compilation Mar 28, 2025
@thePunderWoman
thePunderWoman marked this pull request as ready for review March 28, 2025 18:43
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 28, 2025
@pullapprove
pullapprove Bot requested a review from AleksanderBodurri March 28, 2025 18:43
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker labels Mar 28, 2025
@thePunderWoman
thePunderWoman requested review from alxhub and removed request for AleksanderBodurri March 28, 2025 18:43
@pullapprove
pullapprove Bot requested a review from AleksanderBodurri March 28, 2025 18:44
AndrewKushnir
AndrewKushnir reviewed Mar 28, 2025
View reviewed changes
Comment thread packages/compiler-cli/test/ngtsc/defer_spec.ts Resolved
Comment thread packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts Resolved
Comment thread packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts Resolved
@thePunderWoman
thePunderWoman removed the request for review from AleksanderBodurri March 28, 2025 19:10
@thePunderWoman
fix(core): prevent omission of deferred pipes in full compilation
789cdbf 
This prevents a bug where pipes would be excluded from defer dependency generation.
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 28, 2025
@thePunderWoman
thePunderWoman removed the request for review from alxhub March 31, 2025 13:10
thePunderWoman added a commit that referenced this pull request Mar 31, 2025
@thePunderWoman
fix(core): prevent omission of deferred pipes in full compilation (#6…
dbbddd1 
…0571)

This prevents a bug where pipes would be excluded from defer dependency generation.

PR Close #60571
@thePunderWoman

thePunderWoman commented Mar 31, 2025

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository by commit 005ad65.

The changes were merged into the following branches: main, 19.2.x

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented May 1, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 1, 2025
@thePunderWoman
thePunderWoman deleted the fix-localdeps branch May 23, 2025 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@thePunderWoman @AndrewKushnir