Skip to content

fix(compiler-cli): Produce fatal diagnostic on duplicate decorated pr… - #60376

Closed
atscott wants to merge 1 commit into
angular:mainfrom
atscott:duplicatedecorated
Closed

atscott wants to merge 1 commit into
angular:mainfrom
atscott:duplicatedecorated

Conversation

@atscott

@atscott atscott commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

…operties

This prevents the compilation and language service from crashing.

fixes angular/vscode-ng-language-service#2091

@atscott atscott added the target: patch This PR is targeted for the next patch release label Mar 13, 2025
@atscott
atscott requested a review from crisbeto March 13, 2025 18:03
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 13, 2025
@ngbot ngbot Bot added this to the Backlog milestone Mar 13, 2025
…operties

This prevents the compilation and language service from crashing.

fixes angular/vscode-ng-language-service#2091

@pkozlowski-opensource pkozlowski-opensource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@pullapprove
pullapprove Bot requested a review from mmalerba March 17, 2025 10:23

@thePunderWoman thePunderWoman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 27, 2025
@thePunderWoman
thePunderWoman removed the request for review from alxhub March 27, 2025 19:46
thePunderWoman pushed a commit that referenced this pull request Mar 27, 2025
…operties (#60376)

This prevents the compilation and language service from crashing.

fixes angular/vscode-ng-language-service#2091

PR Close #60376
@thePunderWoman

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 5948cd0.

The changes were merged into the following branches: main, 19.2.x

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language server crash on duplicate decorated properties

5 participants