fix(migrations): Mark hoisted properties as removed in inject migration#58804
Closed
RussellSprouts wants to merge 1 commit intoangular:mainfrom
Closed
fix(migrations): Mark hoisted properties as removed in inject migration#58804RussellSprouts wants to merge 1 commit intoangular:mainfrom
RussellSprouts wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
approved these changes
Nov 21, 2024
Before, in a situation like shown in the test, all of the initializers would be dropped, as the code would try to insert it at the hoisted property which is going to be deleted.
49f9da0 to
609472d
Compare
crisbeto
approved these changes
Nov 21, 2024
Contributor
|
This PR was merged into the repository by commit 3fc14ec. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, in a situation like shown in the test, all of the initializers would be dropped, as the code would try to insert it at the hoisted property which is going to be deleted.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Given this code:
With the internal migration enabled, the new lines of code would be dropped and this would be the output:
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
The internal migration would result in failures with some files.
Other information