fix(compiler-cli): report individual diagnostics for unused imports#58589
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler-cli): report individual diagnostics for unused imports#58589crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Initially the unused imports check was implemented so that it reports one diagnostic per component with the individual unused imports being highlighted through the `relatedInformation`. This works fine when reporting errors to the command line, but vscode appears to only show `relatedInformation` when the user hovers over a diagnostic which is a sub-par experience. These changes switch to reporting a diagnostic for each unused import instead.
devversion
approved these changes
Nov 11, 2024
packages/language-service/src/codefixes/fix_unused_standalone_imports.ts
Show resolved
Hide resolved
clydin
approved these changes
Nov 11, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 11, 2024
…58589) Initially the unused imports check was implemented so that it reports one diagnostic per component with the individual unused imports being highlighted through the `relatedInformation`. This works fine when reporting errors to the command line, but vscode appears to only show `relatedInformation` when the user hovers over a diagnostic which is a sub-par experience. These changes switch to reporting a diagnostic for each unused import instead. PR Close #58589
Contributor
|
This PR was merged into the repository by commit 086cb2c. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially the unused imports check was implemented so that it reports one diagnostic per component with the individual unused imports being highlighted through the
relatedInformation. This works fine when reporting errors to the command line, but vscode appears to only showrelatedInformationwhen the user hovers over a diagnostic which is a sub-par experience.These changes switch to reporting a diagnostic for each unused import instead.
For reference, here's what the diagnostic currently looks like in vscode, after hovering over the node:
