Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 19.2.12
Choose a base ref
...
head repository: angular/angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 19.2.13
Choose a head ref
  • 13 commits
  • 90 files changed
  • 7 contributors

Commits on May 21, 2025

  1. Configuration menu
    Copy the full SHA
    2f5912e View commit details
    Browse the repository at this point in the history

Commits on May 22, 2025

  1. fix(zone.js): classes that extend Error should retain cause property (#…

    …61599)
    
    ZoneAwareError previously did not copy the cause property over to the
    `this` object when an error extends the native error class.
    
    PR Close #61599
    atscott committed May 22, 2025
    Configuration menu
    Copy the full SHA
    5f1bd07 View commit details
    Browse the repository at this point in the history
  2. fix(service-worker): do not register service worker if app is destroy…

    …ed before it is ready to register (#61101)
    
    In this commit, we check whether the application is destroyed before calling `serviceWorker.register(...)`. We should not register the worker because other resources will not be available.
    
    PR Close #61101
    arturovt authored and atscott committed May 22, 2025
    Configuration menu
    Copy the full SHA
    b15bddf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a51f36 View commit details
    Browse the repository at this point in the history
  4. refactor: ensure tsurge migrations have clear ownership of files (#61421

    ) (#61612)
    
    Currently there can be cases, exlusively in 3P, where multiple tsconfig
    projects have overlap of source files. This is the default setup of new
    CLI applications as well.
    
    When this is the case, Tsurge will treat each tsconfig as an isolated
    compilation unit (given the concepts and mental model to support
    scalable batching). This is wrong though, and the same `.ts` source file
    can appear in two migration invocations; resulting in duplicate
    replacements or analysis (depending on the migration).
    
    We've worked around this problem in the past by deduplicating
    replacements, or migrating to an ID-based approach with natural
    deduplication. This worked, but it's just working around the root cause.
    
    This commit attempts to fix the root cause by adjusting Tsurge to ensure
    that no source file ever appears in two compilation units. This is
    naively achieved by not adding a source file to a migration unit, if it
    was part of a previous one. This is expected to be fine given the nature
    of Tsurge migrations that are built to operate on isolated pieces
    anyway— so it shouldn't be problematic if e.g. `app.component.ts` ends
    up being part of the test tsconfig compilation unit (we avoid this order
    though by visiting build targets first).
    
    PR Close #61421
    
    PR Close #61612
    devversion authored and atscott committed May 22, 2025
    Configuration menu
    Copy the full SHA
    1a811c9 View commit details
    Browse the repository at this point in the history
  5. refactor: clean-up deduplication workaround from migrations (#61421) (#…

    …61612)
    
    Since the duplication root-cause was solved by the previous commit, we
    can revert/drop the logic that was added back then to overcome this
    problem with Tsurge.
    
    PR Close #61421
    
    PR Close #61612
    devversion authored and atscott committed May 22, 2025
    Configuration menu
    Copy the full SHA
    c101a3a View commit details
    Browse the repository at this point in the history
  6. refactor: ensure tsurge migrations have clear ownership of files (#61612

    )
    
    This is a patch port of #61421
    
    PR Close #61612
    JeanMeche authored and atscott committed May 22, 2025
    Configuration menu
    Copy the full SHA
    2ae69f7 View commit details
    Browse the repository at this point in the history
  7. build: migrate localize package to use rules_js (#61615)

    Use ts_project to build localize package
    
    PR Close #61615
    josephperrott authored and atscott committed May 22, 2025
    Configuration menu
    Copy the full SHA
    d4d4be8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e38cc41 View commit details
    Browse the repository at this point in the history
  9. build: migrate platform-browser and platform-browser-dynamic package …

    …to use rules_js (#61624)
    
    Use ts_project and ng_project to build platform-browser and platform-browser-dynamic package
    
    PR Close #61624
    josephperrott authored and atscott committed May 22, 2025
    Configuration menu
    Copy the full SHA
    2a26944 View commit details
    Browse the repository at this point in the history
  10. build: migrate platform-server to rules_js (#61619)

    Migrate platform-server to use ts_project and ng_project.
    
    PR Close #61619
    josephperrott authored and atscott committed May 22, 2025
    Configuration menu
    Copy the full SHA
    a6d5479 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2025

  1. fix(common): avoid injecting ApplicationRef in FetchBackend (#61649)

    fixes a circular dependency caused by injecting applicationRef
    
    fixes #61644
    
    PR Close #61649
    atscott committed May 23, 2025
    1 Configuration menu
    Copy the full SHA
    2c876b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    517cde4 View commit details
    Browse the repository at this point in the history
Loading