fix(compiler-cli): resolve TCB mapping failure for safe property reads with as any

atscott · atscott · commit 9218140348cb · 2026-04-06T13:16:19.000-07:00
- Fixes TemplateSymbolBuilder.getTcbPositionForNode to recursively unwrap AsExpression and NonNullExpression nodes. - Added a test case in type_checker__get_symbol_of_template_node_spec.ts to verify symbol mapping when strictSafeNavigationTypes is false. - Note: The issue likely broke in commit 13c8df6.
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/src/template_symbol_builder.ts b/packages/compiler-cli/src/ngtsc/typecheck/src/template_symbol_builder.ts
@@ -831,6 +831,10 @@ export class SymbolBuilder {
       return node.argumentExpression.getStart();
     } else if (ts.isCallExpression(node)) {
       return this.getTcbPositionForNode(node.expression);
+    } else if (ts.isAsExpression(node)) {
+      return this.getTcbPositionForNode(node.expression);
+    } else if (ts.isNonNullExpression(node)) {
+      return this.getTcbPositionForNode(node.expression);
     } else {
       return node.getStart();
     }
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/test/type_checker__get_symbol_of_template_node_spec.ts b/packages/compiler-cli/src/ngtsc/typecheck/test/type_checker__get_symbol_of_template_node_spec.ts
@@ -28,6 +28,7 @@ import {
   ParseTemplateOptions,
   TmplAstComponent,
   MatchSource,
+  SafePropertyRead,
 } from '@angular/compiler';
 import ts from 'typescript';
 
@@ -843,6 +844,38 @@ runInEachFileSystem(() => {
           ).toEqual('string');
         });
 
+        it('safe property reads with as any (failure case)', () => {
+          const fileName = absoluteFrom('/main.ts');
+          const templateString = `<div [inputA]="route?.data?.icon"></div>`;
+          const {templateTypeChecker, program} = setup(
+            [
+              {
+                fileName,
+                templates: {'Cmp': templateString},
+                source: `
+                interface Route {
+                  data: { icon: string; };
+                }
+                export class Cmp { route?: Route; }
+              `,
+              },
+            ],
+            {strictSafeNavigationTypes: false},
+          );
+          const sf = getSourceFileOrError(program, fileName);
+          const cmp = getClass(sf, 'Cmp');
+          const nodes = getAstElements(templateTypeChecker, cmp);
+          const ast = (nodes[0].inputs[0].value as ASTWithSource).ast as PropertyRead;
+          const dataRead = ast.receiver as SafePropertyRead;
+          const dataSymbol = templateTypeChecker.getSymbolOfNode(dataRead, cmp)!;
+          assertExpressionSymbol(dataSymbol);
+          expect(
+            program
+              .getTypeChecker()
+              .symbolToString(templateTypeChecker.getTsSymbolOfSymbol(dataSymbol)!),
+          ).toEqual('data');
+        });
+
         it('ternary expressions', () => {
           const nodes = getAstElements(templateTypeChecker, cmp);
 
