fix(rpc-client): return error instead of panic on unexpected batch response#3807
Merged
mattsse merged 1 commit intoalloy-rs:mainfrom Mar 19, 2026
Merged
fix(rpc-client): return error instead of panic on unexpected batch response#3807mattsse merged 1 commit intoalloy-rs:mainfrom
mattsse merged 1 commit intoalloy-rs:mainfrom
Conversation
mattsse
approved these changes
Mar 19, 2026
Member
mattsse
left a comment
There was a problem hiding this comment.
Reviewed locally; looks good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input comes from external transports/nodes, so a protocol-violating batch response is possible in practice. A panic amplifies a single anomalous response into a full process failure, which is disproportionate.