Remove Request.wait_for_disconnection() method#8636
Conversation
| can get exception information. Returns True if the client disconnects | ||
| prematurely. | ||
| """ | ||
| request._finish() |
There was a problem hiding this comment.
@webknjaz Would be good if you can sanity check whether this method still makes sense. It was added only for this wait_for_disconnection() method, but then appears you added some multipart fix into the method. I'm wondering if that fix should live somewhere else, or we should keep the method.
There was a problem hiding this comment.
I assume your fix was never backported either: #5494.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8636 +/- ##
==========================================
+ Coverage 97.90% 97.93% +0.02%
==========================================
Files 107 107
Lines 33471 33458 -13
Branches 3938 3936 -2
==========================================
- Hits 32769 32766 -3
+ Misses 518 510 -8
+ Partials 184 182 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'm in the process of preparing .2 so I'll merge this one shortly unless there are any objections. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 51d872e on top of patchback/backports/3.10/51d872e1b87480b84a1a541af394a34b311ec22c/pr-8636 Backporting merged PR #8636 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 51d872e on top of patchback/backports/3.11/51d872e1b87480b84a1a541af394a34b311ec22c/pr-8636 Backporting merged PR #8636 into master
🤖 @patchback |
(cherry picked from commit 51d872e)
(cherry picked from commit 51d872e)
…on() method (#8650) Co-authored-by: Sam Bull <git@sambull.org>
…on() method (#8651) Co-authored-by: Sam Bull <git@sambull.org>
Fixes #8631.