Group tar's output to prevent it from messing up action logs#94
Merged
JamesMGreene merged 2 commits intoactions:mainfrom Feb 7, 2024
Merged
Group tar's output to prevent it from messing up action logs#94JamesMGreene merged 2 commits intoactions:mainfrom
JamesMGreene merged 2 commits intoactions:mainfrom
Conversation
SilverRainZ
added a commit
to sphinx-notes/pages
that referenced
this pull request
Feb 2, 2024
When it is used as a component of a composite action.
JamesMGreene
approved these changes
Feb 7, 2024
Contributor
JamesMGreene
left a comment
There was a problem hiding this comment.
Seems like a very reasonable improvement. Thank you for your contribution! 💝
Contributor
|
This has been released as part of |
SilverRainZ
added a commit
to sphinx-notes/pages
that referenced
this pull request
May 2, 2024
SilverRainZ
added a commit
to sphinx-notes/pages
that referenced
this pull request
May 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello maintainers, Please let me know if this PR is unreasonable.
When running a GitHub workflow, outputs of an action will be automatically grouped by step, but when an action is used as a component of another composite action, outputs from different components have no difference, so authors often use
echo ::group::Fooandecho ::endgroup::to distinguish them.So when this action is used in composite action (in this case, it is sphinx-notes/pages), the output of
tarcommand messes up logs (especially when there are many files to be archived).For example:
So I patch this action, re-run the job, and everything goes well.
In addition, maybe the IO flush policy of grouped messages is different, and the running duration is accelerated by 1 minute.