Skip to content

abort the build on the error#935

Merged
dsame merged 6 commits intoactions:mainfrom
akv-platform:invalid-creds2
Mar 20, 2023
Merged

abort the build on the error#935
dsame merged 6 commits intoactions:mainfrom
akv-platform:invalid-creds2

Conversation

@dsame
Copy link
Copy Markdown
Contributor

@dsame dsame commented Feb 10, 2023

Description:
Current logic assumes the build is not interrupted on some exception. This leads the build looks succeeded while it is failed in fact.

The PR makeы the build to fail if some of them have happened.

Related issue:
link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame force-pushed the invalid-creds2 branch 2 times, most recently from 4d1e2fb to ae382cd Compare February 10, 2023 11:44
@dsame dsame marked this pull request as ready for review February 13, 2023 07:36
@dsame dsame requested a review from a team as a code owner February 13, 2023 07:36
@IvanZosimov IvanZosimov self-requested a review February 13, 2023 09:46
Comment thread src/classes/issues-processor.ts Outdated
Comment thread src/classes/issues-processor.ts Outdated
Comment thread package.json Outdated
@dsame dsame force-pushed the invalid-creds2 branch 8 times, most recently from c584de6 to b1cebe0 Compare February 14, 2023 11:25
Comment thread package.json Outdated
Comment thread src/classes/issues-processor.ts Outdated
Comment thread src/classes/issues-processor.ts Outdated
@dsame dsame force-pushed the invalid-creds2 branch 2 times, most recently from d1d7035 to 6f4f2e2 Compare February 27, 2023 19:34
@dsame dsame merged commit 01aa532 into actions:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants