Skip to content

Upgrade Node to v20#1110

Merged
aparnajyothi-y merged 10 commits intoactions:mainfrom
aparnajyothi-y:branch-stale
Dec 7, 2023
Merged

Upgrade Node to v20#1110
aparnajyothi-y merged 10 commits intoactions:mainfrom
aparnajyothi-y:branch-stale

Conversation

@aparnajyothi-y
Copy link
Copy Markdown
Contributor

@aparnajyothi-y aparnajyothi-y commented Nov 24, 2023 •
edited
Loading

Description:
Code changes for Node version upgrade to 20

Related issue:
Feature request

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@aparnajyothi-y aparnajyothi-y requested a review from a team as a code owner November 24, 2023 13:42
@aparnajyothi-y
Copy link
Copy Markdown
Contributor Author

aparnajyothi-y commented Dec 1, 2023

Please review this PR. Thank you.

MaksimZhukov
MaksimZhukov reviewed Dec 6, 2023
View reviewed changes
Comment thread package.json Outdated
{
"name": "stale-action",
"version": "7.0.0",
"version": "8.0.0",
Copy link
Copy Markdown
Contributor

@MaksimZhukov MaksimZhukov Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "8.0.0",
"version": "9.0.0",

IvanZosimov
IvanZosimov reviewed Dec 6, 2023
View reviewed changes
Comment thread src/classes/issues-processor.ts Outdated
Comment on lines +36 to +42

type state_reason_type =
| 'completed'
| 'reopened'
| 'not_planned'
| null
| undefined;
Copy link
Copy Markdown
Contributor

@IvanZosimov IvanZosimov Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for adding this type?

Copy link
Copy Markdown
Contributor Author

@aparnajyothi-y aparnajyothi-y Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I was running npm run test few test and test suites are failed for the code
state_reason: this.options.closeIssueReason || undefined for that I have intialized status_reason and updated the line of code. Now I have rechecked the code and updated the line. All tests passed with same line now.

Comment thread src/classes/issues-processor.ts Outdated
issue_number: issue.number,
state: 'closed',
state_reason: this.options.closeIssueReason || undefined
state_reason: this.options.closeIssueReason as state_reason_type
Copy link
Copy Markdown
Contributor

@IvanZosimov IvanZosimov Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this code update, you changed the logic. The this.options.closeIssueReason is typed as a string. The code state_reason: this.options.closeIssueReason || undefined means that if the this.options.closeIssueReason is an empty string we assign state_reason with undefined.
In your version of code this logic is changed. If the this.options.closeIssueReason is an empty string you assign state_reason with an empty string. What is the reason for that?

Copy link
Copy Markdown
Contributor Author

@aparnajyothi-y aparnajyothi-y Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve the failed tests for that particular line I have added the change and I missed the logic that I am assigning the empty string. Now I have updated the logic. Thank you for the clarification.

@aparnajyothi-y aparnajyothi-y merged commit 28ca103 into actions:main Dec 7, 2023
julioc-lopez pushed a commit to julioc-lopez/zk that referenced this pull request Dec 8, 2023
@dependabot
Bump actions/stale from 8 to 9 (#36)
7b8128d 
Bumps actions/stale from 8 to 9.

Release notes
Sourced from actions/stale's releases.

v9.0.0
Breaking Changes
Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.
Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.
What Else Changed
Performance optimization that removes unnecessary API calls by @​dsame #1033 fixes #792
Logs displaying current github API rate limit by @​dsame #1032 addresses #1029
For more information, please read the action documentation and its section about statefulness

New Contributors
@​jmeridth made their first contribution in actions/stale#984
@​nikolai-laevskii made their first contribution in actions/stale#1020
@​dusan-trickovic made their first contribution in actions/stale#1056
@​aparnajyothi-y made their first contribution in actions/stale#1110
Full Changelog: actions/stale@v8...v9.0.0
julioc-lopez pushed a commit to julioc-lopez/zk that referenced this pull request Dec 8, 2023
@dependabot @julioc-lopez
Bump actions/stale from 8 to 9 (#36)
3a94681 
Bumps actions/stale from 8 to 9.

Release notes
Sourced from actions/stale's releases.

v9.0.0
Breaking Changes
Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.
Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.
What Else Changed
Performance optimization that removes unnecessary API calls by @​dsame #1033 fixes #792
Logs displaying current github API rate limit by @​dsame #1032 addresses #1029
For more information, please read the action documentation and its section about statefulness

New Contributors
@​jmeridth made their first contribution in actions/stale#984
@​nikolai-laevskii made their first contribution in actions/stale#1020
@​dusan-trickovic made their first contribution in actions/stale#1056
@​aparnajyothi-y made their first contribution in actions/stale#1110
Full Changelog: actions/stale@v8...v9.0.0
julioc-lopez pushed a commit to julioc-lopez/zk that referenced this pull request Dec 8, 2023
@dependabot @julioc-lopez
Bump actions/stale from 8 to 9 (#36)
39ba92a 
Bumps actions/stale from 8 to 9.

Release notes
Sourced from actions/stale's releases.

v9.0.0
Breaking Changes
Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.
Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.
What Else Changed
Performance optimization that removes unnecessary API calls by @​dsame #1033 fixes #792
Logs displaying current github API rate limit by @​dsame #1032 addresses #1029
For more information, please read the action documentation and its section about statefulness

New Contributors
@​jmeridth made their first contribution in actions/stale#984
@​nikolai-laevskii made their first contribution in actions/stale#1020
@​dusan-trickovic made their first contribution in actions/stale#1056
@​aparnajyothi-y made their first contribution in actions/stale#1110
Full Changelog: actions/stale@v8...v9.0.0
@SvenStaehs SvenStaehs mentioned this pull request Dec 12, 2023
Open
julioc-lopez pushed a commit to julioc-lopez/zk that referenced this pull request Jan 9, 2024
@dependabot @julioc-lopez
Bump actions/stale from 8 to 9 (#36)
db69f26 
Bumps actions/stale from 8 to 9.

Release notes
Sourced from actions/stale's releases.

v9.0.0
Breaking Changes
Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.
Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.
What Else Changed
Performance optimization that removes unnecessary API calls by @​dsame #1033 fixes #792
Logs displaying current github API rate limit by @​dsame #1032 addresses #1029
For more information, please read the action documentation and its section about statefulness

New Contributors
@​jmeridth made their first contribution in actions/stale#984
@​nikolai-laevskii made their first contribution in actions/stale#1020
@​dusan-trickovic made their first contribution in actions/stale#1056
@​aparnajyothi-y made their first contribution in actions/stale#1110
Full Changelog: actions/stale@v8...v9.0.0
@coderabbitai coderabbitai Bot mentioned this pull request Mar 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@MaksimZhukov MaksimZhukov MaksimZhukov approved these changes

@IvanZosimov IvanZosimov IvanZosimov approved these changes

@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes

@Cabo999 Cabo999 Cabo999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aparnajyothi-y @MaksimZhukov @IvanZosimov @marko-zivic-93 @Cabo999