feat(options): simplify config by removing skip stale message options#457
Merged
luketomlinson merged 3 commits intoactions:mainfrom May 25, 2021
Merged
Conversation
Contributor
Author
|
@luketomlinson good candidate for a major release! |
luketomlinson
approved these changes
May 25, 2021
Collaborator
luketomlinson
left a comment
There was a problem hiding this comment.
I like it. Make it a little simpler
Collaborator
|
@C0ZEN Some conflicts now ☝️ |
Closes actions#405 Closes actions#455 BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message
also lint some files
b251314 to
ad75fc3
Compare
Contributor
Author
|
@luketomlinson handled |
Contributor
Author
|
@luketomlinson thanks. Did you see my message about the breaking change? |
Collaborator
|
yep @C0ZEN I think we can major version here pretty soon |
Contributor
Author
|
So, what about #414? |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
skip-stale-issue-messageandskip-stale-pr-messagestale-issue-messageandstale-pr-messageare unset since it should be optional to comment and should not be a reason to exit the workflowstale-issue-messageandstale-pr-messageare setOther
Closes #405
Closes #455
BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message