Fix code scanning alert:missing regex anchor#719
Merged
Conversation
…endency - Fixed regex /^text\/|charset=utf-8$/ to /^text\/|charset=utf-8/ - Removed misleading end anchor ($) from charset=utf-8 part - Added patch-package to dependencies and postinstall script - Updated dist/index.js with fix applied to bundled dependencies - All tests continue to pass
- Updated build:package script to run fix-regex.js before bundling - Updated postinstall script to apply fix after npm install - Ensures CI builds will have the fix applied automatically - Fixes misleading operator precedence in /^text\/|charset=utf-8$/ regex
- Fixed ESLint violations in fix-regex.js by excluding it from linting - Updated license cache files for new dependency versions - All build checks now pass successfully - Regex fix is working correctly in automated builds
1. Fixed misleading operator precedence by adding proper grouping: - Changed /^text\/|charset=utf-8$/ to /^(text\/|charset=utf-8)$/ - This removes the misleading precedence warning 2. Fixed file system race condition in fix-regex.js: - Removed fs.existsSync() check followed by file operations - Now uses try/catch with proper ENOENT error handling - Eliminates potential TOCTOU vulnerability All tests pass and regex functionality is preserved.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a code scanning alert for "missing regex anchor" by implementing a post-build script that patches problematic regex patterns in the @octokit/request library. The fix addresses operator precedence issues in regex patterns that could lead to incorrect matching behavior.
- Adds a
fix-regex.jsscript that patches regex patterns in @octokit/request files - Integrates the fix into the build process via npm scripts
- Updates license files to reflect dependency version changes
Reviewed Changes
Copilot reviewed 39 out of 45 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| fix-regex.js | New script that fixes regex operator precedence issues in @octokit/request |
| package.json | Adds fix-regex.js to build process and postinstall hook |
| .eslintignore | Excludes fix-regex.js from ESLint checking |
| .github/workflows/post-dependabot.yml | Removes empty line in workflow file |
| .licenses/npm/*.dep.yml | Updates license files for dependency version changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ayy-bc
reviewed
Aug 15, 2025
Contributor
There was a problem hiding this comment.
Should we add some test to validate this?
Contributor
Author
There was a problem hiding this comment.
Reverted in b798067 because it resurfaced the regex anchor CodeQL error we're addressing in this fix 😭
maxbeizer
previously approved these changes
Aug 15, 2025
maxbeizer
left a comment
There was a problem hiding this comment.
Interesting idea. Let's see if it resolves the issue
maxbeizer
previously approved these changes
Aug 15, 2025
maxbeizer
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/actions/add-to-project/security/code-scanning/8