move package library.plantuml -> library.plantuml.rules#959
Merged
codecholeric merged 4 commits intomainfrom Sep 25, 2022
Merged
move package library.plantuml -> library.plantuml.rules#959codecholeric merged 4 commits intomainfrom
library.plantuml -> library.plantuml.rules#959codecholeric merged 4 commits intomainfrom
Conversation
hankem
approved these changes
Sep 19, 2022
While trivial we should still test this function to avoid regression. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
57ab799 to
29b6d84
Compare
hankem
approved these changes
Sep 24, 2022
Member
hankem
left a comment
There was a problem hiding this comment.
Thanks for explicitly declaring @PublicAPI at the class level! 💙
This was a hacky shortcut, but we should in general never mock value objects (but use factories instead), since it destroys invariants and makes the code hard to maintain (as this case shows, because I stumbled over it when I wanted to make `JavaClass` `final` and this test broke as a result). Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
So far we only marked members that were accessible as `@PublicAPI`, which made classes `@PublicAPI` implicitly. Some classes are also marked as `@PublicAPI` at the class level. We should make this consistent and easy to understand for users, so we mark every class toplevel as `@PublicAPI` that is part of the public API. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
... to free up the namespace for further possible enhancements around PlantUML. Our upcoming `1.0.0` release is the perfect point in time to do this breaking change. This will allow us to also add some infrastructure to create diagrams in the future within the `library.plantuml` package and make it clear that all existing code has the context of creating rules from PlantUML. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
50f1b9f to
45e8cd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to free up the namespace for further possible enhancements around PlantUML. Our upcoming
1.0.0release is the perfect point in time to do this breaking change. This will allow us to also add some infrastructure to create diagrams in the future within thelibrary.plantumlpackage and make it clear that all existing code has the context of creating rules from PlantUML.Signed-off-by: Peter Gafert peter.gafert@tngtech.com