Revert "Emit http.disconnect on server shutdown for streaming responses" (#2829)#2913
Merged
Conversation
…ing down for streaming responses (#2829)" This reverts commit 587042d. Requiring a second CTRL+C on streaming apps is expected behavior. Process managers like Kubernetes send a second signal (SIGKILL) after the graceful shutdown timeout, so apps relying on the graceful period to flush work will be force-killed on the second signal as intended.
Contributor
|
📖 Docs preview: https://01c679b9.uvicorn.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #2829.
Requiring a second CTRL+C to force-quit a streaming app is the expected behavior. Infra/process managers (Kubernetes, systemd, etc.) send a second signal after the graceful shutdown period expires, which will force-kill the process exactly as the user intends. Apps that use the graceful window to flush in-flight work should not have that window cut short by a cascading
http.disconnecton the first signal.AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.