Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Kitware/CMake
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.30.4
Choose a base ref
...
head repository: Kitware/CMake
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.30.5
Choose a head ref
  • 3 commits
  • 5 files changed
  • 2 contributors

Commits on Oct 7, 2024

  1. project: Only check non-cache vars when setting project vars

    The change in commit 86ad7cc (project: Only define non-cache vars if
    already defined, 2024-09-15, v3.30.4~2^2) was meant to only check for
    non-cache variables when deciding whether to set non-cache project
    variables for the current call.  However, it erroneously checked for any
    variable, including cache variables.  This gives the intended result on
    the first run, but on subsequent runs a cache variable will exist that
    did not on the first run, leading to different behavior between the two
    runs.  Fix the logic to only check for a pre-existing non-cache
    variable, as was originally intended.
    
    Fixes: #26355
    craigscott-crascit authored and bradking committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    fa07ddf View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge topic 'project-vars' into release-3.30

    fa07ddf project: Only check non-cache vars when setting project vars
    
    Acked-by: Kitware Robot <kwrobot@kitware.com>
    Tested-by: buildbot <buildbot@kitware.com>
    Merge-request: !9883
    bradking authored and kwrobot committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    f9324a7 View commit details
    Browse the repository at this point in the history
  2. CMake 3.30.5

    bradking committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    9c4a0a9 View commit details
    Browse the repository at this point in the history
Loading