-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Comparing changes
Open a pull request
base repository: Kitware/CMake
base: v3.29.6
head repository: Kitware/CMake
compare: v3.29.7
- 10 commits
- 15 files changed
- 1 contributor
Commits on Jun 14, 2024
-
ctest: Fix spurious build failures with CTEST_USE_LAUNCHERS on Windows
Remove the stdio handle inheritance suppression originally added by commit f262298 (... do not inherit pipes in child procs for ctest so it can kill them, 2007-09-11, v2.6.0~1136). It's not clear what problem it was trying to solve, was only done in `ctest` and not `cmake`, and since commit 9c3ffe2 (BUG: fix problem with stdout and stderr not showing up in ms dos shells, 2007-09-25, v2.6.0~1066) has not been done in `ctest` launched under interactive consoles. Furthermore, the code has been spuriously breaking stdio when `ctest` is started with both stdout and stderr connected to the same pipe, such as when `ctest --launch` is used under `ninja`. This is because it used `DuplicateHandle` with `DUPLICATE_CLOSE_SOURCE` on the stdout handle and then the stderr handle. If the handles are the same, then the stderr handle becomes invalid in between these operations, leading to likely-undefined behavior. Since commit 96b3dd3 (cmCTestLaunchReporter: Replace cmsysProcess with cmUVProcessChain, 2023-07-26, v3.28.0-rc1~138^2~2) this became more noticeable because `uv_spawn` performs additional verification on stdio handles. This could be fixed by instead suppressing inheritance via SetHandleInformation(h, HANDLE_FLAG_INHERIT, 0); However, the functionality no longer seems necessary, so remove it.
Configuration menu - View commit details
-
Copy full SHA for e4d0169 - Browse repository at this point
Copy the full SHA e4d0169View commit details
Commits on Jun 21, 2024
-
libuv: macos: reap child processes more reliably when using kqueue
Backport libuv commit `42cc412c4a` (darwin,process: feed kevent the signal to reap children, 2023-02-01, `v1.45.0~55`) from libuv PR 3893. Fixes: #25839
Configuration menu - View commit details
-
Copy full SHA for 7e3519e - Browse repository at this point
Copy the full SHA 7e3519eView commit details -
libuv: macos: restore use of kqueue instead of posix poll
Revert commit f54ec4e (libuv: macos: use posix poll instead of kqueue, 2024-03-31, v3.29.1~7^2) and its parent. It is not necessary after the kqueue-based implementation was fixed to reap child processes more reliably. Issue: #25839
Configuration menu - View commit details
-
Copy full SHA for 422c1de - Browse repository at this point
Copy the full SHA 422c1deView commit details
Commits on Jun 24, 2024
-
VS: Fix '-T version=14.4x' under VS 17.1x
Starting with VS 17.10 the v143 toolset reserves versions `14.30` through `14.49`. This is the first time that the first three digits of the version do not match the toolset name. Extend the special case from commit d256581 (VS: Fix '-T version=14.40' under VS 17.10 preview 1, 2024-02-19, v3.29.0-rc2~10^2) to cover the entire reserved version range.
Configuration menu - View commit details
-
Copy full SHA for dfe0f3f - Browse repository at this point
Copy the full SHA dfe0f3fView commit details -
Merge topic 'ctest-windows-std-handles' into release-3.29
e4d0169 ctest: Fix spurious build failures with CTEST_USE_LAUNCHERS on Windows Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9598
Configuration menu - View commit details
-
Copy full SHA for 1c4c5ad - Browse repository at this point
Copy the full SHA 1c4c5adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1deb543 - Browse repository at this point
Copy the full SHA 1deb543View commit details -
Merge topic 'vs-17.11' into release-3.29
dfe0f3f VS: Fix '-T version=14.4x' under VS 17.1x Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9622
Configuration menu - View commit details
-
Copy full SHA for be53dcd - Browse repository at this point
Copy the full SHA be53dcdView commit details
Commits on Jul 2, 2024
-
Merge topic 'ctest-windows-std-handles' into release-3.28
e4d0169 ctest: Fix spurious build failures with CTEST_USE_LAUNCHERS on Windows Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9598
Configuration menu - View commit details
-
Copy full SHA for 012bca3 - Browse repository at this point
Copy the full SHA 012bca3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee6ff50 - Browse repository at this point
Copy the full SHA ee6ff50View commit details
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 928571f - Browse repository at this point
Copy the full SHA 928571fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.29.6...v3.29.7