Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Kitware/CMake
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.29.4
Choose a base ref
...
head repository: Kitware/CMake
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.29.5
Choose a head ref
  • 5 commits
  • 5 files changed
  • 2 contributors

Commits on Jun 5, 2024

  1. ctest: Set close-on-exec for jobserver FIFO

    Set the close-on-exec flag to prevent the jobserver FIFO file
    descriptor from leaking to subprocesses spawned by `ctest`.
    
    This leak is usually harmless, but can cause `make test -jN` to hang
    at the end of the build if a test leaves a background process running
    with the jobserver FIFO file descriptor open.
    
    Fixes: #26027
    joanbm authored and bradking committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    ff077af View commit details
    Browse the repository at this point in the history
  2. CPack/WiX: Restore default (missing) InstallScope from 3.28 and lower

    In commit 60661f6 (CPack/WiX: Make InstallScope configurable,
    2023-11-07, v3.29.0-rc1~413^2) the `CPACK_WIX_INSTALL_SCOPE` default was
    set to `perMachine`.  While installers created with `perMachine` have
    better behavior on their own than installers created without any
    `InstallScope`, they do not cleanly convert existing installations on
    updates.
    
    Fixes: #26029
    bradking committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    0167089 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge topic 'ctest-jobserver-fifo-hang' into release-3.29

    ff077af ctest: Set close-on-exec for jobserver FIFO
    
    Acked-by: Kitware Robot <kwrobot@kitware.com>
    Merge-request: !9580
    bradking committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    20d1f96 View commit details
    Browse the repository at this point in the history
  2. Merge topic 'backport-3.29-cpack-wix-scope-default' into release-3.29

    0167089 CPack/WiX: Restore default (missing) InstallScope from 3.28 and lower
    
    Acked-by: Kitware Robot <kwrobot@kitware.com>
    Merge-request: !9586
    bradking committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    74e233e View commit details
    Browse the repository at this point in the history
  3. CMake 3.29.5

    bradking committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    facfba0 View commit details
    Browse the repository at this point in the history
Loading