-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Comparing changes
Open a pull request
base repository: Kitware/CMake
base: v3.23.4
head repository: Kitware/CMake
compare: v3.23.5
- 14 commits
- 19 files changed
- 2 contributors
Commits on Oct 10, 2022
-
CPack/NSIS: Fix installer not waiting for uninstaller to finish
In commit b795c96 (CPack/NSIS: Fix uninstall command when run from installer, 2022-03-21, v3.23.0-rc5~9^2~1) we incorrectly removed the `_?` parameter when calling the uninstaller during installation. This parameter is however essential for ExecWait to actually wait for the uninstaller to finish. Without it, the uninstaller is started in the background and installer and uninstaller run at the same time. See https://nsis.sourceforge.io/Docs/Chapter3.html#installerusageuninstaller Add back the `_?` parameter to fix this regression. Use another approach to solve the problem motivating the original change. Fixes: #24041
Configuration menu - View commit details
-
Copy full SHA for 8721658 - Browse repository at this point
Copy the full SHA 8721658View commit details -
Merge branch 'cpack-nsis-uninstaller' into release-3.23
Merge-request: !7774
Configuration menu - View commit details
-
Copy full SHA for d82e2d5 - Browse repository at this point
Copy the full SHA d82e2d5View commit details
Commits on Oct 14, 2022
-
Help: Add versionadded for string(TIMESTAMP) %f specifier
This was accidentally left out of commit c050d6a (string(TIMESTAMP): add %f specifier for microseconds, 2022-01-27, v3.23.0-rc1~59^2).
Configuration menu - View commit details
-
Copy full SHA for 7d25ae7 - Browse repository at this point
Copy the full SHA 7d25ae7View commit details -
Merge branch 'doc-timestamp-f' into release-3.23
Merge-request: !7796
Configuration menu - View commit details
-
Copy full SHA for 367f10f - Browse repository at this point
Copy the full SHA 367f10fView commit details
Commits on Oct 18, 2022
-
try_compile: Honor CMP0128 setting in test project
Some projects pass a raw `-std=` flag to the compiler in the `try_compile` project. If they do not set CMP0128 to NEW, we should not append a `-std=` flag where we did not before the policy was added. Fixes: #24063
Configuration menu - View commit details
-
Copy full SHA for 50e90e2 - Browse repository at this point
Copy the full SHA 50e90e2View commit details -
Merge branch 'try_compile-CMP0128' into release-3.23
Merge-request: !7803
Configuration menu - View commit details
-
Copy full SHA for 96172ba - Browse repository at this point
Copy the full SHA 96172baView commit details
Commits on Oct 20, 2022
-
cm/filesystem: Fix crash with pre-C++11 std::string GNU ABI in C++17
The `remove_filename` and `replace_extension` methods compute an offset between the whole path in a `std::string` and a part of a path in a `std::string_view`. This is done by subtracting their `.data()` pointers. However, C++17 adds a non-const `.data()` through which modification of the string is allowed. This means the copy-on-write implementation used by the pre-C++11 std::string GNU ABI must reallocate if the string has been copied. Our subtraction then computes an offset between two different allocations, which is undefined behavior. The workaround in commit b3ca4f9 (cm/filesystem: Work around crash when compiled for CYGWIN/MSYS runtime, 2021-04-22, v3.21.0-rc1~271^2~2) avoided the problem by calling the non-const `.data()` to reallocate before constructing the `string_view`. Instead, explicitly call the const `.data()` method on the string, which does not reallocate. Fixes: #22090, #23328
Configuration menu - View commit details
-
Copy full SHA for ee9805c - Browse repository at this point
Copy the full SHA ee9805cView commit details -
Merge branch 'filesystem-path-c++03-abi' into release-3.23
Merge-request: !7813
Configuration menu - View commit details
-
Copy full SHA for 199b3e5 - Browse repository at this point
Copy the full SHA 199b3e5View commit details
Commits on Oct 24, 2022
-
Tests: Avoid running C++11 test on GNU < 4.7
The test added in commit 50e90e2 (try_compile: Honor CMP0128 setting in test project, 2022-10-18, v3.25.0-rc2~4^2) requires that the compiler support C++11 mode, so do not run it on GNU compilers that are too old.
Configuration menu - View commit details
-
Copy full SHA for 9028779 - Browse repository at this point
Copy the full SHA 9028779View commit details -
Merge branch 'try_compile-CMP0128' into release-3.23
Merge-request: !7821
Configuration menu - View commit details
-
Copy full SHA for 4f2bb02 - Browse repository at this point
Copy the full SHA 4f2bb02View commit details
Commits on Oct 26, 2022
-
Ninja: Restore support for non-ascii paths on Windows with ninja<=1.10
Revert commit bbdb000 (GlobalNinjaGenerator: enlarge file stream buffer, 2022-01-25, v3.23.0-rc1~68^2). Somehow `rdbuf()->pubsetbuf()` is resetting our imbued locale and `cm_codecvt` that handles encoding. Fixes: #24089
Configuration menu - View commit details
-
Copy full SHA for 02a04dd - Browse repository at this point
Copy the full SHA 02a04ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for a120506 - Browse repository at this point
Copy the full SHA a120506View commit details
Commits on Oct 27, 2022
-
Merge branch 'ninja-intl-paths' into release-3.23
Merge-request: !7833
Configuration menu - View commit details
-
Copy full SHA for cd5826f - Browse repository at this point
Copy the full SHA cd5826fView commit details
Commits on Nov 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 91ccfa3 - Browse repository at this point
Copy the full SHA 91ccfa3View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.23.4...v3.23.5