Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Kitware/CMake
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.23.4
Choose a base ref
...
head repository: Kitware/CMake
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.23.5
Choose a head ref
  • 14 commits
  • 19 files changed
  • 2 contributors

Commits on Oct 10, 2022

  1. CPack/NSIS: Fix installer not waiting for uninstaller to finish

    In commit b795c96 (CPack/NSIS: Fix uninstall command when run from
    installer, 2022-03-21, v3.23.0-rc5~9^2~1) we incorrectly removed the
    `_?` parameter when calling the uninstaller during installation.
    This parameter is however essential for ExecWait to actually wait for
    the uninstaller to finish.  Without it, the uninstaller is started in
    the background and installer and uninstaller run at the same time.
    
    See https://nsis.sourceforge.io/Docs/Chapter3.html#installerusageuninstaller
    
    Add back the `_?` parameter to fix this regression.  Use another
    approach to solve the problem motivating the original change.
    
    Fixes: #24041
    mika-fischer authored and bradking committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    8721658 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'cpack-nsis-uninstaller' into release-3.23

    Merge-request: !7774
    bradking committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    d82e2d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Help: Add versionadded for string(TIMESTAMP) %f specifier

    This was accidentally left out of commit c050d6a (string(TIMESTAMP):
    add %f specifier for microseconds, 2022-01-27, v3.23.0-rc1~59^2).
    bradking committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    7d25ae7 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'doc-timestamp-f' into release-3.23

    Merge-request: !7796
    bradking committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    367f10f View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. try_compile: Honor CMP0128 setting in test project

    Some projects pass a raw `-std=` flag to the compiler in the
    `try_compile` project.  If they do not set CMP0128 to NEW,
    we should not append a `-std=` flag where we did not before
    the policy was added.
    
    Fixes: #24063
    bradking committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    50e90e2 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'try_compile-CMP0128' into release-3.23

    Merge-request: !7803
    bradking committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    96172ba View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. cm/filesystem: Fix crash with pre-C++11 std::string GNU ABI in C++17

    The `remove_filename` and `replace_extension` methods compute an offset
    between the whole path in a `std::string` and a part of a path in a
    `std::string_view`.  This is done by subtracting their `.data()`
    pointers.  However, C++17 adds a non-const `.data()` through which
    modification of the string is allowed.  This means the copy-on-write
    implementation used by the pre-C++11 std::string GNU ABI must reallocate
    if the string has been copied.  Our subtraction then computes an offset
    between two different allocations, which is undefined behavior.
    
    The workaround in commit b3ca4f9 (cm/filesystem: Work around crash
    when compiled for CYGWIN/MSYS runtime, 2021-04-22, v3.21.0-rc1~271^2~2)
    avoided the problem by calling the non-const `.data()` to reallocate
    before constructing the `string_view`.  Instead, explicitly call the
    const `.data()` method on the string, which does not reallocate.
    
    Fixes: #22090, #23328
    bradking committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    ee9805c View commit details
    Browse the repository at this point in the history
  2. Merge branch 'filesystem-path-c++03-abi' into release-3.23

    Merge-request: !7813
    bradking committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    199b3e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Tests: Avoid running C++11 test on GNU < 4.7

    The test added in commit 50e90e2 (try_compile: Honor CMP0128 setting
    in test project, 2022-10-18, v3.25.0-rc2~4^2) requires that the compiler
    support C++11 mode, so do not run it on GNU compilers that are too old.
    bradking committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    9028779 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'try_compile-CMP0128' into release-3.23

    Merge-request: !7821
    bradking committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    4f2bb02 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Ninja: Restore support for non-ascii paths on Windows with ninja<=1.10

    Revert commit bbdb000 (GlobalNinjaGenerator: enlarge file stream
    buffer, 2022-01-25, v3.23.0-rc1~68^2).  Somehow `rdbuf()->pubsetbuf()`
    is resetting our imbued locale and `cm_codecvt` that handles encoding.
    
    Fixes: #24089
    bradking committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    02a04dd View commit details
    Browse the repository at this point in the history
  2. Tests: Add case for ninja with non-ascii chars

    Issue: #24089
    bradking committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    a120506 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge branch 'ninja-intl-paths' into release-3.23

    Merge-request: !7833
    bradking committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    cd5826f View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. CMake 3.23.5

    bradking committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    91ccfa3 View commit details
    Browse the repository at this point in the history
Loading