AppEngineAuthenticator does need to extend LoginAuthenticator for EE10#247
Merged
copybara-service[bot] merged 2 commits intomainfrom Jul 12, 2024
Merged
AppEngineAuthenticator does need to extend LoginAuthenticator for EE10#247copybara-service[bot] merged 2 commits intomainfrom
copybara-service[bot] merged 2 commits intomainfrom
Conversation
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
ludoch
approved these changes
Jul 11, 2024
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
PiperOrigin-RevId: 651633992 Change-Id: I8566531e14d1776e938c9297000a66deb789949d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason for the EE10
AppEngineAuthenticatorto extendLoginAuthenticator, so instead it should implementAuthenticatordirectly.