Skip to content

Use @actions/artifact#24

Merged
GeekyEggo merged 4 commits intoGeekyEggo:mainfrom
s-weigand:use-actions-artifact
Mar 18, 2024
Merged

Use @actions/artifact#24
GeekyEggo merged 4 commits intoGeekyEggo:mainfrom
s-weigand:use-actions-artifact

Conversation

@s-weigand
Copy link
Copy Markdown
Contributor

@s-weigand s-weigand commented Mar 15, 2024

This replaces ArtifactClient with DefaultArtifactClient from @actions/artifact, eliminating the need for a token and fixing permission errors.

closes #19
closes #21

@jsnel
Copy link
Copy Markdown

jsnel commented Mar 17, 2024

The PR branch has been successfully tested in our CI, here.

Screenshot for posterity:
image

@GeekyEggo
Copy link
Copy Markdown
Owner

Thanks for your help @s-weigand, these changes look good. 🙌

To reduce the risk of introducing a regression, and for sanity's sake, I'll publish these as a new major release, v5.

@GeekyEggo GeekyEggo merged commit 7467c3c into GeekyEggo:main Mar 18, 2024
@s-weigand s-weigand deleted the use-actions-artifact branch March 18, 2024 12:21
@s-weigand s-weigand restored the use-actions-artifact branch March 19, 2024 00:06
@s-weigand s-weigand deleted the use-actions-artifact branch July 14, 2024 12:39
Comment thread action.yml
@@ -8,6 +8,7 @@ inputs:
description: GitHub token with read and write access to actions for the repository.
required: true
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default token is not read automatically Tip: @actions/artifact added methods to delete artifacts

4 participants