Merged
Conversation
Member
pvaneck
commented
Feb 10, 2026
- Update changelog with new version
- Add urljoin fix from core
0774794 to
ec70164
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates corehttp for the next beta release and pulls in an _urljoin behavior fix to prevent adding an extra trailing slash when appending query-only URL templates (affecting PipelineClientBase.format_url behavior).
Changes:
- Bumped
corehttpversion to1.0.0b8and added an unreleased changelog entry. - Updated
_urljointo skip path modification when the stub has no path segment. - Added unit tests validating
_urljoinbehavior for query-only and other edge cases.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/core/corehttp/corehttp/runtime/_base.py | Adjusts _urljoin to avoid appending "/" when stub_url has no path component. |
| sdk/core/corehttp/tests/test_pipeline.py | Adds a new test covering _urljoin edge cases (including query-only stubs). |
| sdk/core/corehttp/corehttp/_version.py | Bumps package version to 1.0.0b8. |
| sdk/core/corehttp/CHANGELOG.md | Adds 1.0.0b8 (Unreleased) entry documenting the URL formatting fix. |
ec70164 to
cd14187
Compare
- Update changelog with new version - Add urljoin fix from core Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
cd14187 to
ac23f49
Compare
lmazuel
approved these changes
Feb 19, 2026
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.