Feature: Option to disable creation of initial connection #12965

Activity

1. titanism

   added

   enhancementThis issue is a user-facing general improvement that doesn't fix a bug or add a new featureThis issue is a user-facing general improvement that doesn't fix a bug or add a new feature

   new featureThis change adds new functionality, like a new method or classThis change adds new functionality, like a new method or class

   on Jan 31, 2023
2. titanism commented on Jan 31, 2023

   

   titanism

   on Jan 31, 2023

   Author

   More actions

   This might not actually be too hard, but we could be wrong:

     // default global options
     this.options = Object.assign({
       pluralization: true,
       autoIndex: true,
   -    autoCreate: true
   +    autoCreate: true,
   +    createInitialConnection: false
     }, options);
   +
   +  if (this.options.createInitialConnection) {
   +    const conn = this.createConnection(); // default connection
   +    conn.models = this.models;
   +  }
   
   -  const conn = this.createConnection(); // default connection
   -  conn.models = this.models;
3. titanism commented on Jan 31, 2023

   

   titanism

   on Jan 31, 2023

   Author

   More actions

   There might also be another bug here we discovered, whereas id is not unique.

   mongoose/lib/connection.js

   Lines 72 to 76 in 9d7bf10

   	if (typeof base === 'undefined' || !base.connections.length) {
   	this.id = 0;
   	} else {
   	this.id = base.connections.length;
   	}

   If you create multiple connections, then call .destroy() on them, and then create more connections, multiple of the connections will have the same id property because .length does not check for uniqueness.

   cc @vkarpov15
4. titanism commented on Jan 31, 2023

   

   titanism

   on Jan 31, 2023

   Author

   More actions

   Confirmed this is a bug!

   const mongoose = require('mongoose');
   mongoose.createConnection()
   mongoose.createConnection()
   mongoose.connections[0].destroy()
   mongoose.createConnection()
   mongoose.createConnection()
   mongoose.createConnection()
   mongoose.connections.map(c => c.id) // outputs: [ 1, 2, 3, 3, 4 ]

   You can see 3 appears twice.
5. vkarpov15

   added this to the 6.9.2 milestone on Feb 10, 2023
6. lpizzinidev

   added a commit that references this issue on Feb 11, 2023

   feat(index): added createInitialConnection option to Mongoose constru…

   ...

   This issue will close once commit 6e5176a is merged into the 'master' branch.

   6e5176a
7. vkarpov15

   added a commit that references this issue on Feb 13, 2023

   Merge pull request #13021 from lpizzinidev/gh-12965

   ...

   4b71e8e
8. vkarpov15

   modified the milestones: 6.9.2, 6.9.4, 6.10.0 on Feb 16, 2023
9. vkarpov15

   added a commit that references this issue on Feb 22, 2023

   feat(index): added createInitialConnection option to Mongoose constru…

   ...

   This issue will close once commit c3c133b is merged into the 'master' branch.

   c3c133b
10. vkarpov15

    closed this as completedon Feb 22, 2023
11. Say383

    added a commit that references this issue on Mar 30, 2023

    [Snyk] Upgrade mongoose from 6.8.0 to 6.10.2 (#6)

    ...

    b9da1b0