Skip to content

fix(index.d.ts): add CastError constructor - #10176

Merged
vkarpov15 merged 1 commit into
Automattic:masterfrom
michaln-q:gh-10146
Apr 28, 2021
Merged

vkarpov15 merged 1 commit into
Automattic:masterfrom
michaln-q:gh-10146

Conversation

@michaln-q

Copy link
Copy Markdown
Contributor

Summary

Should fix #10146

Comment thread index.d.ts Outdated
reason?: NativeError | null;
model?: any;

constructor(type: string, value: any, path: string, reason?: NativeError);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be 1 more parameter: schemaType?: SchemaType . Can you add that please?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, fixed.

@vkarpov15 vkarpov15 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 5.12.7 milestone Apr 28, 2021
@vkarpov15
vkarpov15 merged commit 33f30b2 into Automattic:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing typescript typings (CastError constructor)

2 participants