fix: add missing constraints for aside element to have the implicit complementary role#558
Merged
Conversation
…mplementary` role
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Pull Request Test Coverage Report for Build 9821929894Details
💛 - Coveralls |
samccone
added a commit
to samccone/aria-query
that referenced
this pull request
Jul 7, 2024
As discovered in A11yance#554 Address the defect introduced f7f6120#r143856081 This change depends on A11yance#558 which when applied (as in this PR makes the teset cases pass)
samccone
approved these changes
Jul 8, 2024
ljharb
pushed a commit
to samccone/aria-query
that referenced
this pull request
Jul 8, 2024
As discovered in A11yance#554 Address the defect introduced f7f6120#r143856081 This change depends on A11yance#558 which when applied (as in this PR makes the teset cases pass)
ljharb
pushed a commit
to samccone/aria-query
that referenced
this pull request
Jul 8, 2024
As discovered in A11yance#554 Address the defect introduced f7f6120#r143856081 This change depends on A11yance#558 which when applied (as in this PR makes the teset cases pass)
ljharb
pushed a commit
to samccone/aria-query
that referenced
this pull request
Jul 8, 2024
As discovered in A11yance#554 Address the defect introduced f7f6120#r143856081 This change depends on A11yance#558 which when applied (as in this PR makes the teset cases pass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #526
This change adds the missing constraints for the
asideelement to have the implicitcomplementaryrole.REF: https://www.w3.org/TR/html-aam-1.0/#el-aside-ancestorbodymain
Note the use of two constraints rather than a single for "body or main" is to mirror precedent set by existing constraints, e.g. see the constraints for
tdwithgridcellrole, as well asheaderorfooterconstraints for thegenericrole as examples.