fix: Fix python unit tests (feast-dev#3734)

crispin-ki · zseta · commit f5d7f0443359 · 2024-02-07T11:02:16.000+01:00
* Fix regex log_string_to_wait_for to be more generic for changing versions of mysql

Signed-off-by: Crispin Logan &lt;crispin.logan@ki-insurance.com&gt;

* Add noqa otherwise flake incorrectly flags W605

Signed-off-by: Crispin Logan &lt;crispin.logan@ki-insurance.com&gt;

---------

Signed-off-by: Crispin Logan &lt;crispin.logan@ki-insurance.com&gt;
Signed-off-by: Attila Toth &lt;hello@attilatoth.dev&gt;
diff --git a/sdk/python/tests/unit/test_sql_registry.py b/sdk/python/tests/unit/test_sql_registry.py
@@ -91,7 +91,7 @@ def mysql_registry():
     container.start()
 
     # The log string uses '8.0.*' since the version might be changed as new Docker images are pushed.
-    log_string_to_wait_for = "/usr/sbin/mysqld: ready for connections. Version: '8.0.*'  socket: '/var/run/mysqld/mysqld.sock'  port: 3306"
+    log_string_to_wait_for = "/usr/sbin/mysqld: ready for connections. Version: '(\d+(\.\d+){1,2})'  socket: '/var/run/mysqld/mysqld.sock'  port: 3306"  # noqa: W605
     waited = wait_for_logs(
         container=container,
         predicate=log_string_to_wait_for,
