Skip to content

Commit 7c93b7c

Browse files
authored
gh-95778: CVE-2020-10735: Prevent DoS by very large int() (#96499)
Integer to and from text conversions via CPython's bignum `int` type is not safe against denial of service attacks due to malicious input. Very large input strings with hundred thousands of digits can consume several CPU seconds. This PR comes fresh from a pile of work done in our private PSRT security response team repo. Signed-off-by: Christian Heimes [Red Hat] <christian@python.org> Tons-of-polishing-up-by: Gregory P. Smith [Google] <greg@krypto.org> Reviews via the private PSRT repo via many others (see the NEWS entry in the PR). <!-- gh-issue-number: gh-95778 --> * Issue: gh-95778 <!-- /gh-issue-number --> I wrote up [a one pager for the release managers](https://docs.google.com/document/d/1KjuF_aXlzPUxTK4BMgezGJ2Pn7uevfX7g0_mvgHlL7Y/edit#). Much of that text wound up in the Issue. Backports PRs already exist. See the issue for links.
1 parent 11d2f1e commit 7c93b7c

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

idlelib/idle_test/test_sidebar.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import unittest
77
import unittest.mock
88
from test.support import requires, swap_attr
9+
from test import support
910
import tkinter as tk
1011
from idlelib.idle_test.tkinter_testing_utils import run_in_tk_mainloop
1112

@@ -612,7 +613,8 @@ def test_interrupt_recall_undo_redo(self):
612613

613614
@run_in_tk_mainloop()
614615
def test_very_long_wrapped_line(self):
615-
with swap_attr(self.shell, 'squeezer', None):
616+
with support.adjust_int_max_str_digits(11_111), \
617+
swap_attr(self.shell, 'squeezer', None):
616618
self.do_input('x = ' + '1'*10_000 + '\n')
617619
yield
618620
self.assertEqual(self.get_sidebar_lines(), ['>>>'])

0 commit comments

Comments
 (0)