Logging: pass in parameters to workers (googleapis#4369)

chemelnucfin · web-flow · commit 2a3793d0d682 · 2017-11-09T12:55:59.000-08:00
* closes googleapis#4365 - pass in parameters to workers * review changes
diff --git a/logging/google/cloud/logging/handlers/transports/background_thread.py b/logging/google/cloud/logging/handlers/transports/background_thread.py
@@ -255,7 +255,9 @@ def __init__(self, client, name, grace_period=_DEFAULT_GRACE_PERIOD,
                  batch_size=_DEFAULT_MAX_BATCH_SIZE):
         self.client = client
         logger = self.client.logger(name)
-        self.worker = _Worker(logger)
+        self.worker = _Worker(logger,
+                              grace_period=grace_period,
+                              max_batch_size=batch_size)
         self.worker.start()
 
     def send(self, record, message, resource=None, labels=None):
diff --git a/logging/tests/unit/handlers/transports/test_background_thread.py b/logging/tests/unit/handlers/transports/test_background_thread.py
@@ -76,6 +76,22 @@ def test_flush(self):
 
         transport.worker.flush.assert_called()
 
+    def test_worker(self):
+        client = _Client(self.PROJECT)
+        name = 'python_logger'        
+        batch_size = 30
+        grace_period = 20.
+        transport, worker = self._make_one(client,
+                                           name,
+                                           grace_period=grace_period,
+                                           batch_size=batch_size)
+        worker_grace_period = worker.call_args[1]['grace_period']  # **kwargs.
+        worker_batch_size = worker.call_args[1]['max_batch_size']
+        self.assertEqual(worker_grace_period,
+                         grace_period)
+        self.assertEqual(worker_batch_size,
+                         batch_size)
+
 
 class Test_Worker(unittest.TestCase):
     NAME = 'python_logger'
