Cleanup: unnecessary includes, fix include order, fix unreferenced va… (cppcheck-opensource#3418)

chrchr-github · web-flow · commit d9b69400704a · 2021-08-26T19:36:31.000+02:00
diff --git a/cli/cppcheckexecutor.cpp b/cli/cppcheckexecutor.cpp
@@ -68,11 +68,13 @@
 #include <execinfo.h>
 #endif
 
+#if defined(_WIN32)
 #if defined(_MSC_VER)
 #define USE_WINDOWS_SEH
+#endif
+#include <Windows.h>
 #include <DbgHelp.h>
 #include <TCHAR.H>
-#include <Windows.h>
 #include <excpt.h>
 #endif
 
diff --git a/cli/threadexecutor.cpp b/cli/threadexecutor.cpp
@@ -32,8 +32,6 @@
 #include <cstring>
 #include <iostream>
 #include <utility>
-#include <future>
-#include <numeric>
 
 #ifdef __SVR4  // Solaris
 #include <sys/loadavg.h>
@@ -48,8 +46,8 @@
 #include <unistd.h>
 #endif
 #ifdef THREADING_MODEL_WIN
-#include <process.h>
-#include <windows.h>
+#include <future>
+#include <numeric>
 #endif
 
 // required for FD_ZERO
diff --git a/cli/threadexecutor.h b/cli/threadexecutor.h
@@ -33,8 +33,6 @@
 #define THREADING_MODEL_FORK
 #elif defined(_WIN32)
 #define THREADING_MODEL_WIN
-#include <windows.h>
-
 #include "importproject.h"
 #endif
 
diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -2263,7 +2263,7 @@ bool Tokenizer::simplifyUsing()
             Token::Match(tok, "using namespace %name% ;|::")) {
             try {
                 setScopeInfo(tok, &currentScope, mSettings->debugwarnings);
-            } catch (const std::runtime_error &e) {
+            } catch (const std::runtime_error &) {
                 reportError(tok, Severity::debug, "simplifyUsingUnmatchedBodyEnd",
                             "simplifyUsing: unmatched body end");
             }
@@ -2417,7 +2417,7 @@ bool Tokenizer::simplifyUsing()
                 Token::Match(tok1, "using namespace %name% ;|::")) {
                 try {
                     setScopeInfo(tok1, &currentScope1, mSettings->debugwarnings);
-                } catch (const std::runtime_error &e) {
+                } catch (const std::runtime_error &) {
                     reportError(tok1, Severity::debug, "simplifyUsingUnmatchedBodyEnd",
                                 "simplifyUsing: unmatched body end");
                 }
