Synchronize handling of datetime in Packer implementations (msgpack#434)

yanlend · web-flow · commit 772c830841a2 · 2020-07-24T16:29:15.000+09:00
The handling of datetime is different in the cython and Python implementations. In contrast to the docs, timezone is not required in the Python implementation.
diff --git a/msgpack/fallback.py b/msgpack/fallback.py
@@ -921,7 +921,7 @@ def _pack(
                     len(obj), dict_iteritems(obj), nest_limit - 1
                 )
 
-            if self._datetime and check(obj, _DateTime):
+            if self._datetime and check(obj, _DateTime) and obj.tzinfo is not None:
                 obj = Timestamp.from_datetime(obj)
                 default_used = 1
                 continue

Original file line number	Diff line number	Diff line change
`@@ -921,7 +921,7 @@ def _pack(`
`921`	`921`	`len(obj), dict_iteritems(obj), nest_limit - 1`
`922`	`922`	`)`
`923`	`923`
`924`		`- if self._datetime and check(obj, _DateTime):`
	`924`	`+ if self._datetime and check(obj, _DateTime) and obj.tzinfo is not None:`
`925`	`925`	`obj = Timestamp.from_datetime(obj)`
`926`	`926`	`default_used = 1`
`927`	`927`	`continue`