Remove dependency on ts-mock-imports. (#18425)

karthiknadig · web-flow · commit b38ea75a8ec1 · 2022-02-03T09:19:05.000-08:00
diff --git a/news/3 Code Health/14757.md b/news/3 Code Health/14757.md
@@ -0,0 +1 @@
+Remove dependency on `ts-mock-imports`.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2049,7 +2049,6 @@
         "sinon": "^8.0.1",
         "source-map-support": "^0.5.12",
         "ts-loader": "^5.3.0",
-        "ts-mock-imports": "^1.3.0",
         "ts-mockito": "^2.5.0",
         "ts-node": "^8.3.0",
         "tsconfig-paths-webpack-plugin": "^3.2.0",
diff --git a/src/test/pythonEnvironments/base/info/environmentInfoService.functional.test.ts b/src/test/pythonEnvironments/base/info/environmentInfoService.functional.test.ts
@@ -5,7 +5,6 @@
 
 import * as assert from 'assert';
 import * as sinon from 'sinon';
-import { ImportMock } from 'ts-mock-imports';
 import { SemVer } from 'semver';
 import { ExecutionResult } from '../../../../client/common/process/types';
 import { IDisposableRegistry } from '../../../../client/common/types';
@@ -42,9 +41,8 @@ suite('Environment Info Service', () => {
 
     setup(() => {
         disposables = [];
-        stubShellExec = ImportMock.mockFunction(
-            ExternalDep,
-            'shellExecute',
+        stubShellExec = sinon.stub(ExternalDep, 'shellExecute');
+        stubShellExec.returns(
             new Promise<ExecutionResult<string>>((resolve) => {
                 resolve({
                     stdout:
diff --git a/src/test/pythonEnvironments/base/locators/composite/envsResolver.unit.test.ts b/src/test/pythonEnvironments/base/locators/composite/envsResolver.unit.test.ts
@@ -5,7 +5,6 @@ import { assert } from 'chai';
 import { cloneDeep } from 'lodash';
 import * as path from 'path';
 import * as sinon from 'sinon';
-import { ImportMock } from 'ts-mock-imports';
 import { EventEmitter, Uri } from 'vscode';
 import { ExecutionResult } from '../../../../../client/common/process/types';
 import { IDisposableRegistry } from '../../../../../client/common/types';
@@ -92,9 +91,8 @@ suite('Python envs locator - Environments Resolver', () => {
         let stubShellExec: sinon.SinonStub;
         setup(() => {
             sinon.stub(platformApis, 'getOSType').callsFake(() => platformApis.OSType.Windows);
-            stubShellExec = ImportMock.mockFunction(
-                externalDependencies,
-                'shellExecute',
+            stubShellExec = sinon.stub(externalDependencies, 'shellExecute');
+            stubShellExec.returns(
                 new Promise<ExecutionResult<string>>((resolve) => {
                     resolve({
                         stdout:
@@ -243,9 +241,8 @@ suite('Python envs locator - Environments Resolver', () => {
         let stubShellExec: sinon.SinonStub;
         setup(() => {
             sinon.stub(platformApis, 'getOSType').callsFake(() => platformApis.OSType.Windows);
-            stubShellExec = ImportMock.mockFunction(
-                externalDependencies,
-                'shellExecute',
+            stubShellExec = sinon.stub(externalDependencies, 'shellExecute');
+            stubShellExec.returns(
                 new Promise<ExecutionResult<string>>((resolve) => {
                     resolve({
                         stdout:
diff --git a/src/test/pythonEnvironments/common/environmentManagers/simplevirtualenvs.unit.test.ts b/src/test/pythonEnvironments/common/environmentManagers/simplevirtualenvs.unit.test.ts
@@ -5,7 +5,6 @@ import * as assert from 'assert';
 import * as fsapi from 'fs-extra';
 import * as path from 'path';
 import * as sinon from 'sinon';
-import { ImportMock } from 'ts-mock-imports';
 import * as platformUtils from '../../../../client/common/utils/platform';
 import { PythonReleaseLevel, PythonVersion } from '../../../../client/pythonEnvironments/base/info';
 import * as fileUtils from '../../../../client/pythonEnvironments/common/externalDependencies';
@@ -25,11 +24,11 @@ suite('isVenvEnvironment Tests', () => {
     let fileExistsStub: sinon.SinonStub;
 
     setup(() => {
-        fileExistsStub = ImportMock.mockFunction(fileUtils, 'pathExists');
+        fileExistsStub = sinon.stub(fileUtils, 'pathExists');
     });
 
     teardown(() => {
-        fileExistsStub.restore();
+        sinon.restore();
     });
 
     test('pyvenv.cfg does not exist', async () => {
