Merge pull request xtensor-stack#208 from serge-sans-paille/feature/better-error-report-pycontainer

JohanMabille · web-flow · commit 4ffcfb7b5a4e · 2019-11-25T23:01:48.000+01:00
Better error report when facing dimension mismatch
diff --git a/include/xtensor-python/pycontainer.hpp b/include/xtensor-python/pycontainer.hpp
@@ -13,6 +13,7 @@
 #include <cmath>
 #include <functional>
 #include <numeric>
+#include <sstream>
 
 #include "pybind11/complex.h"
 #include "pybind11/pybind11.h"
@@ -356,7 +357,10 @@ namespace xt
             {
                 if(new_dim != N)
                 {
-                    throw std::runtime_error("Dims not matching.");
+                    std::ostringstream err_msg;
+                    err_msg << "Invalid conversion to pycontainer, expecting a container of dimension "
+                            << N << ", got a container of dimension " << new_dim << ".";
+                    throw std::runtime_error(err_msg.str());
                 }
                 return new_dim == N;
             }

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`#include <cmath>`
`14`	`14`	`#include <functional>`
`15`	`15`	`#include <numeric>`
	`16`	`+#include <sstream>`
`16`	`17`
`17`	`18`	`#include "pybind11/complex.h"`
`18`	`19`	`#include "pybind11/pybind11.h"`
`@@ -356,7 +357,10 @@ namespace xt`
`356`	`357`	`{`
`357`	`358`	`if(new_dim != N)`
`358`	`359`	`{`
`359`		`- throw std::runtime_error("Dims not matching.");`
	`360`	`+ std::ostringstream err_msg;`
	`361`	`+ err_msg << "Invalid conversion to pycontainer, expecting a container of dimension "`
	`362`	`+ << N << ", got a container of dimension " << new_dim << ".";`
	`363`	`+ throw std::runtime_error(err_msg.str());`
`360`	`364`	`}`
`361`	`365`	`return new_dim == N;`
`362`	`366`	`}`