Use docker in synth script (googleapis#123)

chingor13 · web-flow · commit c76b742474a9 · 2018-11-08T10:09:41.000-08:00
diff --git a/lib/google_apis/generator/swagger_cli.ex b/lib/google_apis/generator/swagger_cli.ex
@@ -39,20 +39,22 @@ defmodule GoogleApis.Generator.SwaggerCli do
 
   defp generate_code(filename, client_library_name) do
     tmp_dir = temp_path(client_library_name, Application.get_env(:google_apis, :tempdir))
+    File.mkdir_p!(tmp_dir)
 
     with {:ok, volume_name} <- run_docker_command("volume create"),
          {:ok, _} <- run_docker_command("pull #{image()}"),
          {:ok, container} <-
            run_docker_command("container create -v #{volume_name}:/data #{image()}"),
          {:ok, _} <- run_docker_command("cp . #{container}:/data"),
-         {:ok, _} <- run_docker_command("rm #{container}"),
          generate_command =
-           "run --rm -v #{volume_name}:/local -v #{tmp_dir}:/tmp/out #{image()} generate -l elixir -i /local/specifications/openapi/#{
+           "run --rm -v #{volume_name}:/local #{image()} generate -l elixir -i /local/specifications/openapi/#{
              filename
-           } -c /local/specifications/config/#{filename} -t #{template_dir()} -o /tmp/out/#{
+           } -c /local/specifications/config/#{filename} -t #{template_dir()} -o /local/#{
              client_library_name
            }",
-         {:ok, _} <- run_docker_command(generate_command) do
+         {:ok, _} <- run_docker_command(generate_command),
+         {:ok, _} <- run_docker_command("cp #{container}:/data/#{client_library_name} #{tmp_dir}"),
+         {:ok, _} <- run_docker_command("rm #{container}") do
       {:ok, tmp_dir}
     else
       err -> err
diff --git a/scripts/generate_client.sh b/scripts/generate_client.sh
@@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+# Copyright 2018 Google Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+set -eo pipefail
+
+pushd $(dirname "$0")/../
+
+export TEMPLATE=gax
+
+# clean the codegen directory
+# if [ -d .codegen ]; then
+#     rm -rf .codegen
+# fi
+# mkdir -p .codegen
+# export TEMPDIR=$(pwd)/.codegen
+
+# install npm dependencies
+npm install
+
+# install dependencies
+mix deps.get
+
+# run generators
+mix google_apis.generate $1
diff --git a/synth.py b/synth.py
@@ -20,20 +20,25 @@
 import synthtool.shell as shell
 import synthtool.sources.git as git
 import logging
+import sys
 
 logging.basicConfig(level=logging.DEBUG)
 
-repository_url = "https://github.com/GoogleCloudPlatform/elixir-google-api.git"
+repository_url = "https://github.com/googleapis/elixir-google-api.git"
 
 log.debug(f"Cloning {repository_url}.")
 repository = git.clone(repository_url, depth=1)
 
-log.debug("Installing dependencies.")
-shell.run("mix deps.get".split(), cwd=repository)
-shell.run("npm install".split(), cwd=repository)
+image = "gcr.io/cloud-devrel-kokoro-resources/elixir16"
+generate_command = "scripts/generate_client.sh"
+command = f"docker run --rm -v{repository}:/workspace -v/var/run/docker.sock:/var/run/docker.sock -w /workspace {image} {generate_command}"
 
-log.debug("Generating all libraries.")
-shell.run("mix google_apis.generate".split(), cwd=repository)
+if len(sys.argv) == 2:
+    command = command + " " + sys.argv[1]
+
+log.debug(f"Running in docker: {command}")
+
+shell.run(command.split(), cwd=repository)
 
 # copy all clients
 s.copy(repository / "clients")
