fix: parser-configuration should work well with generated completion script (#2332)

AgentEnder · web-flow · commit 888db19ccebc · 2025-04-25T16:42:44.000-04:00
diff --git a/lib/yargs-factory.ts b/lib/yargs-factory.ts
@@ -2058,7 +2058,16 @@ export class YargsInstance {
       this.#isGlobalContext = false;
 
       const handlerKeys = this.#command.getCommands();
-      const requestCompletions = this.#completion!.completionKey in argv;
+
+      const requestCompletions = this.#completion?.completionKey
+        ? [
+            this.#completion?.completionKey,
+            ...(this.getAliases()[this.#completion?.completionKey] ?? []),
+          ].some((key: string) =>
+            Object.prototype.hasOwnProperty.call(argv, key)
+          )
+        : false;
+
       const skipRecommendation = helpOptSet || requestCompletions || helpOnly;
       if (argv._.length) {
         if (handlerKeys.length) {
diff --git a/test/completion.mjs b/test/completion.mjs
@@ -1189,4 +1189,26 @@ describe('Completion', () => {
       });
     });
   });
+
+  describe('parser-configuration', () => {
+    const configurations = [
+      {'strip-dashed': true},
+      {'camel-case-expansion': true, 'strip-aliased': true},
+    ];
+
+    for (const configuration of configurations) {
+      it(`should support ${Object.keys(configuration).join(' ')}`, () => {
+        process.env.SHELL = '/bin/bash';
+
+        const r = checkOutput(
+          () =>
+            yargs(['--get-yargs-completions', 'a'])
+              .parserConfiguration(configuration)
+              .command('apple', 'banana').argv
+        );
+
+        r.logs.should.include('apple');
+      });
+    }
+  });
 });
