Skip to content

Commit af219e7

Browse files
judahrandjudahrand
authored
Parse BQ DATETIME and TIMESTAMP (feast-dev#1885)
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
1 parent 2fccf76 commit af219e7

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎sdk/python/feast/type_map.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,8 +340,8 @@ def pa_to_feast_value_type(pa_type_as_str: str) -> ValueType:
340340

341341
def bq_to_feast_value_type(bq_type_as_str):
342342
type_map: Dict[ValueType, Union[str, Dict[str, Any]]] = {
343-
"DATETIME": ValueType.STRING, # Update to ValueType.UNIX_TIMESTAMP once #1520 lands.
344-
"TIMESTAMP": ValueType.STRING, # Update to ValueType.UNIX_TIMESTAMP once #1520 lands.
343+
"DATETIME": ValueType.UNIX_TIMESTAMP,
344+
"TIMESTAMP": ValueType.UNIX_TIMESTAMP,
345345
"INTEGER": ValueType.INT64,
346346
"INT64": ValueType.INT64,
347347
"STRING": ValueType.STRING,

0 commit comments

Comments
 (0)