Fix PackerConfig.clone()

xerial · xerial · commit 521d493b47a9 · 2016-04-07T08:52:27.000-07:00
diff --git a/msgpack-core/src/main/java/org/msgpack/core/MessagePack.java b/msgpack-core/src/main/java/org/msgpack/core/MessagePack.java
@@ -247,9 +247,9 @@ public PackerConfig()
 
         private PackerConfig(PackerConfig copy)
         {
-            this.smallStringOptimizationThreshold = smallStringOptimizationThreshold;
-            this.bufferFlushThreshold = bufferFlushThreshold;
-            this.bufferSize = bufferSize;
+            this.smallStringOptimizationThreshold = copy.smallStringOptimizationThreshold;
+            this.bufferFlushThreshold = copy.bufferFlushThreshold;
+            this.bufferSize = copy.bufferSize;
         }
 
         @Override
diff --git a/msgpack-core/src/test/scala/org/msgpack/core/MessagePackTest.scala b/msgpack-core/src/test/scala/org/msgpack/core/MessagePackTest.scala
@@ -48,6 +48,28 @@ class MessagePackTest extends MessagePackSpec {
   }
 
   "MessagePack" should {
+
+    "clone packer config" in {
+      val config = new PackerConfig().withBufferSize(10).withBufferFlushThreshold(32 * 1024).withSmallStringOptimizationThreshold(142)
+      val copy = config.clone()
+
+      copy shouldBe config
+    }
+
+    "clone unpacker config" in {
+      val config = new UnpackerConfig()
+              .withBufferSize(1)
+              .withActionOnMalformedString(CodingErrorAction.IGNORE)
+              .withActionOnUnmappableString(CodingErrorAction.REPORT)
+              .withAllowReadingBinaryAsString(false)
+              .withStringDecoderBufferSize(34)
+              .withStringSizeLimit(4324)
+
+      val copy = config.clone()
+      copy shouldBe config
+    }
+
+
     "detect fixint values" in {
 
       for (i <- 0 until 0x79) {

Original file line number	Diff line number	Diff line change
`@@ -247,9 +247,9 @@ public PackerConfig()`
`247`	`247`
`248`	`248`	`private PackerConfig(PackerConfig copy)`
`249`	`249`	`{`
`250`		`- this.smallStringOptimizationThreshold = smallStringOptimizationThreshold;`
`251`		`- this.bufferFlushThreshold = bufferFlushThreshold;`
`252`		`- this.bufferSize = bufferSize;`
	`250`	`+ this.smallStringOptimizationThreshold = copy.smallStringOptimizationThreshold;`
	`251`	`+ this.bufferFlushThreshold = copy.bufferFlushThreshold;`
	`252`	`+ this.bufferSize = copy.bufferSize;`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`@Override`