improve empty spectrogram error message

swharden · swharden · commit 0fd4dce20dac · 2020-07-04T12:18:26.000-04:00
fixes swharden#13
diff --git a/src/Spectrogram.Tests/Mel.cs b/src/Spectrogram.Tests/Mel.cs
@@ -82,5 +82,15 @@ public void Test_Mel_Graph()
 
             plt1.SaveFig("mel1.png");
         }
+
+        [Test]
+        public void Test_SaveEmpty_Throws()
+        {
+            (int sampleRate, double[] audio) = WavFile.ReadMono("../../../../../data/cant-do-that-44100.wav");
+            int fftSize = 4096;
+            var spec = new Spectrogram(sampleRate, fftSize, stepSize: 500);
+            //spec.Add(audio);
+            Assert.Throws<InvalidOperationException>(() => { spec.SaveImage("empty.png"); });
+        }
     }
 }
diff --git a/src/Spectrogram/Spectrogram.cs b/src/Spectrogram/Spectrogram.cs
@@ -182,7 +182,10 @@ public void SaveBitmap(Bitmap bmp, string fileName) { }
 
         public void SaveImage(string fileName, double intensity = 1, bool dB = false, bool roll = false)
         {
-            string extension = System.IO.Path.GetExtension(fileName).ToLower();
+            if (ffts.Count == 0)
+                throw new InvalidOperationException("Spectrogram contains no data. Use Add() to add signal data.");
+
+            string extension = Path.GetExtension(fileName).ToLower();
 
             ImageFormat fmt;
             if (extension == ".bmp")

Original file line number	Diff line number	Diff line change
`@@ -82,5 +82,15 @@ public void Test_Mel_Graph()`
`82`	`82`
`83`	`83`	`plt1.SaveFig("mel1.png");`
`84`	`84`	`}`
	`85`	`+`
	`86`	`+ [Test]`
	`87`	`+ public void Test_SaveEmpty_Throws()`
	`88`	`+ {`
	`89`	`+ (int sampleRate, double[] audio) = WavFile.ReadMono("../../../../../data/cant-do-that-44100.wav");`
	`90`	`+ int fftSize = 4096;`
	`91`	`+ var spec = new Spectrogram(sampleRate, fftSize, stepSize: 500);`
	`92`	`+ //spec.Add(audio);`
	`93`	`+ Assert.Throws<InvalidOperationException>(() => { spec.SaveImage("empty.png"); });`
	`94`	`+ }`
`85`	`95`	`}`
`86`	`96`	`}`